From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-clone.txt: remove the restriction on pushing from a shallow clone
Date: Mon, 15 Jul 2013 08:01:40 +0700 [thread overview]
Message-ID: <CACsJy8Bx_o+9S1N_uieQaV8NBbc3T_MR_VCvF+fM==Dy-vt7tw@mail.gmail.com> (raw)
In-Reply-To: <7vfvvhgeif.fsf@alter.siamese.dyndns.org>
On Mon, Jul 15, 2013 at 1:52 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> On Sun, Jul 14, 2013 at 4:25 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>>> Hi,
>>>
>>> Nguyễn Thái Ngọc Duy wrote:
>>>
>>>> Since 52fed6e (receive-pack: check connectivity before concluding "git
>>>> push" - 2011-09-02), receive-pack is prepared to deal with broken
>>>> push, a shallow push can't cause any corruption. Update the document
>>>> to reflect that.
>>>
>>> Hmm, what happens when pushing to servers without that commit? Do you
>>> think it should be applied to Debian squeeze for server operators that
>>> haven't upgraded yet to the current stable release?
>>
>> This is pushing _from_ a shallow repo, where the sender repo's old
>> objects is a subset of the receiver's.
>
> The "subset" assumption does not necessarily hold, does it? The
> receiver may have rewound its tips and pruned since then.
>
> Also, the sender may have cloned from the receiver (fully) and then
> fetched a different history shallowly from elsewhere. The receiver
> may have no commit on that history, including the shallow-bottom.
>
Hmm.. right. And the receiver needs to setup proper graft to seal the
shallow bottom. So it's really not safe to do pushing from a shallow
repo without 52fed6e
--
Duy
next prev parent reply other threads:[~2013-07-15 1:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 5:37 [PATCH] git-clone.txt: remove the restriction on pushing from a shallow clone Nguyễn Thái Ngọc Duy
2013-07-12 5:53 ` Junio C Hamano
2013-07-12 5:54 ` Junio C Hamano
2013-07-12 7:54 ` Duy Nguyen
2013-07-13 21:25 ` Jonathan Nieder
2013-07-14 2:28 ` Duy Nguyen
2013-07-14 18:52 ` Junio C Hamano
2013-07-15 1:01 ` Duy Nguyen [this message]
2013-07-15 6:33 ` Duy Nguyen
2013-07-15 15:31 ` Junio C Hamano
2013-07-15 15:35 ` [PATCH] Revert "git-clone.txt: remove the restriction on pushing from a shallow clone" Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8Bx_o+9S1N_uieQaV8NBbc3T_MR_VCvF+fM==Dy-vt7tw@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).