From: Duy Nguyen <pclouds@gmail.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
"Git Mailing List" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 1/3] doc: note config file restrictions for completion.commands
Date: Sun, 17 Mar 2019 20:12:51 +0700 [thread overview]
Message-ID: <CACsJy8BuR=syjT1gjTxXXKKaevzpbdRGp+je+rsX6jV96F3sbA@mail.gmail.com> (raw)
In-Reply-To: <20190301173443.16429-2-tmz@pobox.com>
Poking this thread before it goes completely dead...
On Sat, Mar 2, 2019 at 12:34 AM Todd Zullinger <tmz@pobox.com> wrote:
>
> The completion.commands config var must be set in either the system-wide
> or global config file. The completion script does not read a local
> repository config.
After the last discussion, I think the consensus was it's ok to allow
per-repo config so we can just drop this and update the code to read
from any config file, right?
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
> Documentation/config/completion.txt | 3 ++-
> Documentation/git.txt | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/config/completion.txt b/Documentation/config/completion.txt
> index 4d99bf33c9..4859d18e86 100644
> --- a/Documentation/config/completion.txt
> +++ b/Documentation/config/completion.txt
> @@ -4,4 +4,5 @@ completion.commands::
> porcelain commands and a few select others are completed. You
> can add more commands, separated by space, in this
> variable. Prefixing the command with '-' will remove it from
> - the existing list.
> + the existing list. The variable must be set in either the
> + system-wide or global config.
> diff --git a/Documentation/git.txt b/Documentation/git.txt
> index 00156d64aa..638f4d6cc9 100644
> --- a/Documentation/git.txt
> +++ b/Documentation/git.txt
> @@ -172,7 +172,8 @@ foo.bar= ...`) sets `foo.bar` to the empty string which `git config
> others (all other commands in `$PATH` that have git- prefix),
> list-<category> (see categories in command-list.txt),
> nohelpers (exclude helper commands), alias and config
> - (retrieve command list from config variable completion.commands)
> + (retrieve command list from config variable completion.commands,
> + set in the global or system-wide config file)
>
> GIT COMMANDS
> ------------
--
Duy
next prev parent reply other threads:[~2019-03-17 13:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 22:31 [BUG] completion.commands does not remove multiple commands Todd Zullinger
2019-02-28 23:05 ` Jeff King
2019-03-01 17:34 ` Todd Zullinger
2019-03-01 18:30 ` Jeff King
2019-03-01 22:15 ` Todd Zullinger
2019-03-01 23:08 ` Jeff King
2019-03-02 1:08 ` Duy Nguyen
2019-03-02 1:18 ` Junio C Hamano
2019-03-02 2:40 ` Todd Zullinger
2019-03-02 4:07 ` SZEDER Gábor
2019-03-03 1:34 ` Todd Zullinger
2019-03-03 17:06 ` Jeff King
2019-03-01 17:34 ` [PATCH 1/3] doc: note config file restrictions for completion.commands Todd Zullinger
2019-03-17 13:12 ` Duy Nguyen [this message]
2019-03-17 18:16 ` [PATCH v2 0/4] completion.commands: fix multiple command removals Todd Zullinger
2019-03-17 18:16 ` [PATCH v2 1/4] git: read local config in --list-cmds Todd Zullinger
2019-03-18 9:41 ` Duy Nguyen
2019-03-20 18:03 ` [PATCH v3 0/4] completion.commands: fix multiple command removals Todd Zullinger
2019-03-21 2:58 ` Junio C Hamano
2019-03-21 17:18 ` Todd Zullinger
2019-03-21 9:45 ` Duy Nguyen
2019-03-20 18:03 ` [PATCH v3 1/4] git: read local config in --list-cmds Todd Zullinger
2019-03-20 18:03 ` [PATCH v3 2/4] t9902: test multiple removals via completion.commands Todd Zullinger
2019-03-20 18:03 ` [PATCH v3 3/4] completion: fix multiple command removals Todd Zullinger
2019-03-20 18:03 ` [PATCH v3 4/4] completion: use __git when calling --list-cmds Todd Zullinger
2019-03-17 18:16 ` [PATCH v2 2/4] t9902: test multiple removals via completion.commands Todd Zullinger
2019-03-17 18:16 ` [PATCH v2 3/4] completion: fix multiple command removals Todd Zullinger
2019-03-17 18:16 ` [PATCH v2 4/4] completion: use __git when calling --list-cmds Todd Zullinger
2019-03-01 17:34 ` [PATCH 2/3] t9902: test multiple removals via completion.commands Todd Zullinger
2019-03-01 18:22 ` Eric Sunshine
2019-03-01 20:50 ` SZEDER Gábor
2019-03-01 21:56 ` Todd Zullinger
2019-03-01 17:34 ` [PATCH 3/3] completion: fix multiple command removals Todd Zullinger
2019-03-01 18:16 ` Jeff King
2019-02-28 23:05 ` [BUG] completion.commands does not remove multiple commands SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8BuR=syjT1gjTxXXKKaevzpbdRGp+je+rsX6jV96F3sbA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).