git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: Minor bug, git ls-files -o aborts because of broken submodules
Date: Fri, 22 Jan 2016 16:17:29 +0700	[thread overview]
Message-ID: <CACsJy8BpCc6sNKUs3TsMnA_8dk+uFvZy1T_UmfQMxcm2bpg2uw@mail.gmail.com> (raw)

$ git init abc
$ cd abc
$ mkdir def
$ echo 'gitdir: blah blah' >def/.git
$ git ls-files -o
fatal: Not a git repository: def/blah blah

If some directory looks like a submodule but turns out not, that's not
a fatal error. The stack trace is something like this. I suspect
do_submodule_path should use the gently version..

#1  0x0000000000588a78 in die
#2  0x0000000000558ded in read_gitfile_gently
#3  0x000000000051e2f6 in do_submodule_path
#4  0x000000000051e484 in git_pathdup_submodule
#5  0x00000000005340ac in resolve_gitlink_ref_recursive
#6  0x00000000005342cf in resolve_gitlink_ref
#7  0x00000000004dd20d in treat_directory
#8  0x00000000004dd760 in treat_one_path
#9  0x00000000004dd971 in treat_path
#10 0x00000000004de038 in read_directory_recursive
-- 
Duy

             reply	other threads:[~2016-01-22  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22  9:17 Duy Nguyen [this message]
2016-01-22 21:18 ` Minor bug, git ls-files -o aborts because of broken submodules Jeff King
2016-01-22 22:26   ` Jeff King
2016-01-22 22:27     ` [PATCH 1/2] clean: make is_git_repository a public function Jeff King
2016-01-22 22:29     ` [PATCH 2/2] resolve_gitlink_ref: ignore non-repository paths Jeff King
2016-01-22 22:31       ` Jeff King
2016-01-22 22:36         ` Stefan Beller
2016-01-22 22:40           ` Jeff King
2016-01-25 13:13     ` Minor bug, git ls-files -o aborts because of broken submodules Andreas Krey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACsJy8BpCc6sNKUs3TsMnA_8dk+uFvZy1T_UmfQMxcm2bpg2uw@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).