From: Duy Nguyen <pclouds@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: David Turner <novalis@novalis.org>,
Git Mailing List <git@vger.kernel.org>,
Keith McGuigan <kamggg@gmail.com>,
David Turner <dturner@twopensource.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v13 04/20] index-helper: new daemon for caching index and related stuff
Date: Sat, 2 Jul 2016 14:43:23 +0200 [thread overview]
Message-ID: <CACsJy8Bke0EQ9rOEBmz6BcvcfPe-X_rktaOku9F-wUOrnVMJDw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1607021312210.12947@virtualbox>
On Sat, Jul 2, 2016 at 1:20 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>> > -test -n "$NO_MMAP" && {
>> > - skip_all='skipping index-helper tests: no mmap'
>> > +git index-helper -h 2>/dev/null
>> > +test $? = 129 ||
>>
>> So when NO_MMAP is set, "git index-helper -h" will set $? to 1.
>
> Not quite.
>
> When NO_MMAP is set, index-helper will not be compiled. Or at least it
> should not be:
>
>> +ifndef NO_MMAP
>> +ifndef NO_UNIX_SOCKETS
>> + PROGRAM_OBJS += index-helper.o
>> +endif
>> +endif
>
> If it is *unset*, *and* if NO_UNIX_SOCKETS is *also* unset, index-helper
> gets compiled, and -h triggers code in parse-options.c or usage.c that
> exits with status 129.
>
> So I do not think that this is subtle.
The question is "whether index-helper is supported?" but you need to
go through parse-options.c and that strange (to me) exit status 129 to
conclude that index-helper is in fact built. It's not just as straight
forwarding from reading the test.
> But it just occurred to me that the #ifndef NO_MMAP in index-helper.c is
> unnecessary and that its #else clause (containing a loop() that fails)
> contains dead code: we never compile this code with NO_MMAP, and neither
> should we.
Yeah that's probably old code from POSIX shm time. Back then there
were calls to shm_open and stuff, not just mmap.
> Dave, would you mind taking that #ifndef NO_MMAP out of "index-helper: new
> daemon for caching index and related stuff" when you re-roll?
--
Duy
next prev parent reply other threads:[~2016-07-02 12:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 4:14 [PATCH v13 01/20] read-cache.c: fix constness of verify_hdr() David Turner
2016-06-26 4:14 ` [PATCH v13 02/20] read-cache: allow to keep mmap'd memory after reading David Turner
2016-06-26 4:14 ` [PATCH v13 03/20] pkt-line: add gentle version of packet_write David Turner
2016-06-26 4:14 ` [PATCH v13 04/20] index-helper: new daemon for caching index and related stuff David Turner
[not found] ` <CAFUO74nENapwVsM3CUst9AHqy5LcKTFBCnJxGXPk8E952t+X5Q@mail.gmail.com>
2016-06-27 16:53 ` David Turner
2016-06-30 13:06 ` Johannes Schindelin
2016-06-30 15:04 ` Duy Nguyen
2016-07-02 11:20 ` Johannes Schindelin
2016-07-02 12:43 ` Duy Nguyen [this message]
2016-06-26 4:14 ` [PATCH v13 05/20] index-helper: add --strict David Turner
2016-06-26 4:14 ` [PATCH v13 06/20] daemonize(): set a flag before exiting the main process David Turner
2016-06-26 4:14 ` [PATCH v13 07/20] index-helper: add --detach David Turner
2016-06-26 4:14 ` [PATCH v13 08/20] index-helper: log warnings David Turner
2016-06-26 4:14 ` [PATCH v13 09/20] read-cache: add watchman 'WAMA' extension David Turner
2016-06-26 4:14 ` [PATCH v13 10/20] watchman: support watchman to reduce index refresh cost David Turner
2016-06-26 4:14 ` [PATCH v13 11/20] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-06-30 17:55 ` Ben Peart
2016-06-30 19:14 ` Duy Nguyen
2016-06-30 23:54 ` Ben Peart
2016-07-03 12:28 ` Duy Nguyen
2016-07-06 16:54 ` Ben Peart
2016-07-08 16:32 ` Duy Nguyen
2016-07-08 16:39 ` Duy Nguyen
2016-06-26 4:14 ` [PATCH v13 12/20] update-index: enable/disable watchman support David Turner
2016-06-26 4:14 ` [PATCH v13 13/20] unpack-trees: preserve index extensions David Turner
2016-06-26 4:14 ` [PATCH v13 14/20] watchman: add a config option to enable the extension David Turner
2016-06-26 4:14 ` [PATCH v13 15/20] index-helper: kill mode David Turner
2016-06-26 4:14 ` [PATCH v13 16/20] index-helper: don't run if already running David Turner
2016-06-26 4:14 ` [PATCH v13 17/20] index-helper: autorun mode David Turner
2016-06-26 4:14 ` [PATCH v13 18/20] index-helper: optionally automatically run David Turner
2016-06-26 4:14 ` [PATCH v13 19/20] trace: measure where the time is spent in the index-heavy operations David Turner
2016-06-26 12:09 ` [PATCH v13 21/20] unix-socket.c: add stub implementation when unix sockets are not supported Nguyễn Thái Ngọc Duy
2016-06-27 12:14 ` Johannes Schindelin
2016-06-27 16:16 ` Duy Nguyen
2016-06-28 10:06 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8Bke0EQ9rOEBmz6BcvcfPe-X_rktaOku9F-wUOrnVMJDw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kamggg@gmail.com \
--cc=novalis@novalis.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).