git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jan 2018, #04; Wed, 31)
Date: Sat, 10 Feb 2018 17:09:06 +0700	[thread overview]
Message-ID: <CACsJy8BeQ3mD9pReUZKi+=qio5z8an5RyVd=auxPnMZ3uCRhdQ@mail.gmail.com> (raw)
In-Reply-To: <87372am2ls.fsf@evledraar.gmail.com>

On Sat, Feb 10, 2018 at 1:37 AM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> On Thu, Feb 01 2018, Junio C. Hamano jotted:
>
>> * nd/fix-untracked-cache-invalidation (2018-01-24) 5 commits
>>  - dir.c: stop ignoring opendir() error in open_cached_dir()
>>  - update-index doc: note a fixed bug in the untracked cache
>>  - dir.c: fix missing dir invalidation in untracked code
>>  - dir.c: avoid stat() in valid_cached_dir()
>>  - status: add a failing test showing a core.untrackedCache bug
>>
>>  Some bugs around "untracked cache" feature have been fixed.
>>
>>  Will merge to 'next'.
>
> I think you / Nguyễn may not have seen my
> <87d11omi2o.fsf@evledraar.gmail.com>
> (https://public-inbox.org/git/87d11omi2o.fsf@evledraar.gmail.com/)

I have. But since you wrote "I haven't found... yet", I assumed you
were still on it. You didn't give me much info to follow anyway.

> As noted there I think it's best to proceed without the "dir.c: stop
> ignoring opendir[...]" patch.
>
> It's going to be a bad regression in 2.17 if it ends up spewing pagefuls
> of warnings in previously working repos if the UC is on.

"previously working" is a strong word when opendir() starts to
complain. Sure we can suppress/ignore the error messages but I don't
think it's a healthy attitude. Unreported bugs can't be fixed.

We could perhaps stop reporting after we have printed like ... 5 lines
or so? That keeps the noise level down a bit and probably still give
enough indicator to at least repair the cache.
-- 
Duy

  parent reply	other threads:[~2018-02-10 10:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01  0:56 What's cooking in git.git (Jan 2018, #04; Wed, 31) Junio C Hamano
2018-02-01 11:05 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:09   ` Junio C Hamano
2018-02-09 17:06   ` Johannes Schindelin
2018-02-09 18:30     ` Ævar Arnfjörð Bjarmason
2018-02-01 12:11 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:05   ` Junio C Hamano
2018-02-02 19:29     ` Ævar Arnfjörð Bjarmason
2018-02-09 18:37 ` Ævar Arnfjörð Bjarmason
2018-02-09 18:54   ` Junio C Hamano
2018-02-09 21:04     ` [PATCH 0/2] update-index doc: note new caveats in 2.17 Ævar Arnfjörð Bjarmason
2018-02-09 21:40       ` Junio C Hamano
2018-02-09 22:10         ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04     ` [PATCH 1/2] update-index doc: note a fixed bug in the untracked cache Ævar Arnfjörð Bjarmason
2018-02-09 21:52       ` Junio C Hamano
2018-02-09 22:14         ` Ævar Arnfjörð Bjarmason
2018-02-09 22:50           ` Junio C Hamano
2018-02-09 22:58             ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04     ` [PATCH 2/2] update-index doc: note the caveat with "could not open..." Ævar Arnfjörð Bjarmason
2018-02-10 10:09   ` Duy Nguyen [this message]
2018-02-11 14:44     ` What's cooking in git.git (Jan 2018, #04; Wed, 31) Ævar Arnfjörð Bjarmason
2018-02-12 10:04       ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8BeQ3mD9pReUZKi+=qio5z8an5RyVd=auxPnMZ3uCRhdQ@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).