git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð" <avarab@gmail.com>,
	"Christian Couder" <christian.couder@gmail.com>,
	Git <git@vger.kernel.org>, "Jeff King" <peff@peff.net>,
	"David Turner" <dturner@twopensource.com>,
	"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [RFC/PATCH] config: add core.trustmtime
Date: Mon, 30 Nov 2015 20:12:14 +0100	[thread overview]
Message-ID: <CACsJy8BZo4hFz+mQKNxrmPQaGforvguFmjL90g=Hf698okFs2A@mail.gmail.com> (raw)
In-Reply-To: <xmqq610j8fzt.fsf@gitster.mtv.corp.google.com>

On Mon, Nov 30, 2015 at 8:05 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Maybe I'm missing some really common breakage with st_mtime on some
>> system, but having a feature the user explicitly enables turn itself
>> off and doing FS-testing that takes 10 seconds when it's enabled seems
>> like the wrong default to me.
>>
>> We don't do it with core.fileMode, core.ignorecase or core.trustctime
>> or core.symlinks. Do we really need to be treating this differently?
>
> I share the exact thought.  I was looking the other way when
> untracked-cache was done originally ;-), and I would also want to
> know the answers to the above questions.

OK I was just paranoid (and having to look at filesystem source code
to determine if it supported this didn't help either). So I guess that
means we can make the test a separate option, only invoked by the
user, then.
-- 
Duy

  reply	other threads:[~2015-11-30 19:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25  6:35 [RFC/PATCH] config: add core.trustmtime Christian Couder
2015-11-25  9:00 ` Ævar Arnfjörð Bjarmason
2015-11-25 19:51   ` Duy Nguyen
2015-11-26  5:21     ` Christian Couder
2015-11-26 17:53       ` Duy Nguyen
2015-11-27  1:35         ` Ævar Arnfjörð Bjarmason
2015-11-30 19:05           ` Junio C Hamano
2015-11-30 19:12             ` Duy Nguyen [this message]
2015-12-01  5:57             ` Torsten Bögershausen
2015-12-02 19:28   ` Duy Nguyen
2015-12-07  5:42     ` Christian Couder
2015-11-25 10:25 ` Johannes Schindelin
2015-11-25 10:39   ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8BZo4hFz+mQKNxrmPQaGforvguFmjL90g=Hf698okFs2A@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=avarab@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).