From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 5/6] gitignore: do not do basename match with patterns that have '**'
Date: Fri, 5 Oct 2012 18:23:23 +0700 [thread overview]
Message-ID: <CACsJy8BTWEeWvdwCDGBdoLndh8hXpgCgXrQxhWeaO1m9Qrqvgw@mail.gmail.com> (raw)
In-Reply-To: <506E85BF.8010302@viscovery.net>
On Fri, Oct 5, 2012 at 2:01 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Am 10/4/2012 9:39, schrieb Nguyễn Thái Ngọc Duy:
>> - - If the pattern does not contain a slash '/', git treats it as
>> - a shell glob pattern and checks for a match against the
>> - pathname relative to the location of the `.gitignore` file
>> - (relative to the toplevel of the work tree if not from a
>> - `.gitignore` file).
>> + - If the pattern does not contain a slash '/' nor '**', git
>> + treats it as a shell glob pattern and checks for a match
>> + against the pathname relative to the location of the
>> + `.gitignore` file (relative to the toplevel of the work tree
>> + if not from a `.gitignore` file).
I think in the latest round, we forbid this case (i.e. a/**, **/b and
a/**/b are ok, but a**b is not), exactly because it's hard to define
how it should do. Thanks for another example.
>> +test_expect_success '"**" with no slashes test' '
>> + echo "a**f foo=bar" >.gitattributes &&
>> + cat <<\EOF >expect &&
>> +f: foo: unspecified
>> +a/f: foo: bar
>> +a/b/f: foo: bar
>> +a/b/c/f: foo: bar
>> +EOF
>
> Should the above .gitattributes match nested paths, such as b/a/c/f?
>
> I think it should, because the user can easily say "/a**f" that nested
> paths should not be matched.
The user can also say **/a/**f to match b/a/c/f.
--
Duy
next prev parent reply other threads:[~2012-10-05 11:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 23:20 What's cooking in git.git (Oct 2012, #01; Tue, 2) Junio C Hamano
2012-10-03 15:23 ` Nguyen Thai Ngoc Duy
2012-10-03 18:17 ` Junio C Hamano
2012-10-04 1:56 ` Nguyen Thai Ngoc Duy
2012-10-04 6:01 ` Junio C Hamano
2012-10-04 7:39 ` [PATCH 0/6] wildmatch part 2 Nguyễn Thái Ngọc Duy
2012-10-04 7:39 ` [PATCH 1/6] attr: remove the union in struct match_attr Nguyễn Thái Ngọc Duy
2012-10-04 7:39 ` [PATCH 2/6] attr: avoid strlen() on every match Nguyễn Thái Ngọc Duy
2012-10-04 7:39 ` [PATCH 3/6] attr: avoid searching for basename " Nguyễn Thái Ngọc Duy
2012-10-04 7:39 ` [PATCH 4/6] attr: more matching optimizations from .gitignore Nguyễn Thái Ngọc Duy
2012-10-04 7:39 ` [PATCH 5/6] gitignore: do not do basename match with patterns that have '**' Nguyễn Thái Ngọc Duy
2012-10-04 17:59 ` Junio C Hamano
2012-10-05 7:01 ` Johannes Sixt
2012-10-05 11:23 ` Nguyen Thai Ngoc Duy [this message]
2012-10-04 7:39 ` [PATCH 6/6] t3001: note about expected "**" behavior Nguyễn Thái Ngọc Duy
2012-10-04 18:04 ` Junio C Hamano
2012-10-04 17:43 ` [PATCH 0/6] wildmatch part 2 Junio C Hamano
2012-10-04 9:34 ` What's cooking in git.git (Oct 2012, #01; Tue, 2) Michael Haggerty
2012-10-04 11:46 ` Nguyen Thai Ngoc Duy
2012-10-04 15:17 ` Michael Haggerty
2012-10-04 16:39 ` Junio C Hamano
2012-10-05 12:19 ` Andreas Schwab
2012-10-05 12:30 ` Matthieu Moy
2012-10-05 14:15 ` Andreas Schwab
2012-10-05 13:21 ` Nguyen Thai Ngoc Duy
2012-10-04 8:17 ` David Michael Barr
2012-10-04 8:30 ` fa/remote-svn (Re: What's cooking in git.git (Oct 2012, #01; Tue, 2)) Jonathan Nieder
2012-10-04 13:16 ` Stephen Bash
2012-10-04 16:30 ` Junio C Hamano
2012-10-04 16:27 ` What's cooking in git.git (Oct 2012, #01; Tue, 2) Junio C Hamano
2012-10-30 12:15 ` Florian Achleitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8BTWEeWvdwCDGBdoLndh8hXpgCgXrQxhWeaO1m9Qrqvgw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).