git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Junio C Hamano <gitster@pobox.com>,
	Linus <torvalds@linux-foundation.org>
Subject: Re: A local shared clone is now much slower
Date: Mon, 8 Jul 2013 10:20:22 +0700	[thread overview]
Message-ID: <CACsJy8BG0i-ncGTJ+9YkN=R1v6WOqF3MJkv_+572=eDjm-ug1A@mail.gmail.com> (raw)
In-Reply-To: <20130708130355.647fffb6e5b6a453bfa0fa6e@canb.auug.org.au>

On Mon, Jul 8, 2013 at 10:03 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi guys,
>
> So commit 0433ad128c59 ("clone: run check_everything_connected") (which
> turned up with v1.8.3) added a large traversal to clone which (as the
> comment said) makes a clone much slower.  It is especially noticeable on
> "git clone -s -l -n" which I use every day and used to be almost
> instant.  Is there any thought to making it fast again, please?

It's done that way as a security measure against repo corruption.
Although I wonder if we could do connectivity check in background
instead (reports are stored in .git and picked up by git-status). The
same mechanism could be used for "git gc --auto". If the repo turns
out corrupted, the user may lose the last ~10 minutes of work, not
really bad for the speed trade off. This mode is not the default, of
course. The user has to be aware of the risk when choosing this route.
--
Duy

  reply	other threads:[~2013-07-08  3:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08  3:03 A local shared clone is now much slower Stephen Rothwell
2013-07-08  3:20 ` Duy Nguyen [this message]
2013-07-08  4:25   ` Stephen Rothwell
2013-07-08  7:30 ` Jeff King
2013-07-08  8:57   ` Duy Nguyen
2013-07-08 15:00     ` Junio C Hamano
2013-07-09  4:30       ` Jeff King
2013-07-11  9:35       ` Priming git clone with a local repo? Andreas Krey
2013-07-11 16:01         ` Junio C Hamano
2013-07-08 13:05   ` A local shared clone is now much slower Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8BG0i-ncGTJ+9YkN=R1v6WOqF3MJkv_+572=eDjm-ug1A@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).