From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [BUG?] fetch into shallow sends a large number of objects
Date: Wed, 9 Mar 2016 06:02:10 +0700 [thread overview]
Message-ID: <CACsJy8BFK64rzJwQxB8M3=uA_g9s6N70vjNyLOnroZc28soiAQ@mail.gmail.com> (raw)
In-Reply-To: <20160308133041.GA9465@sigill.intra.peff.net>
On Tue, Mar 8, 2016 at 8:30 PM, Jeff King <peff@peff.net> wrote:
> On Tue, Mar 08, 2016 at 08:25:24AM -0500, Jeff King wrote:
>
>> > Good news. We have the mechanism in place, I think.
>> > get_shallow_commits_by_rev_list() (from 'pu') will produce the right
>> > shallow points for sending back to the client if you pass "--not
>> > <current shallow points>" to it. It's meant to be used for
>> > --shallow-exclude and --shallow-since, but if neither is given (nor
>> > --depth) I guess we can run it with current shallow points. I wonder
>> > if we can detect some common cases and avoid commit traversing this
>> > way though.
>>
>> I tried that, but I couldn't quite get it to work. I don't think we need
>> any special rev-list, though; we can just find the boundary points of
>> that traversal and mark them as new shallows.
>
> By the way, I found a bug during my initial attempts with
> get_shallow_commits_by_rev_list().
Hehe. Thanks. Will check why tests missed it and reroll with Ramsay's
fix once -rc period is over.
--
Duy
next prev parent reply other threads:[~2016-03-08 23:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 22:15 [BUG?] fetch into shallow sends a large number of objects Jeff King
2016-03-07 23:47 ` Junio C Hamano
2016-03-08 0:53 ` Duy Nguyen
2016-03-08 12:21 ` Jeff King
2016-03-08 12:14 ` Jeff King
2016-03-08 12:33 ` Duy Nguyen
2016-03-08 13:25 ` Jeff King
2016-03-08 13:30 ` Jeff King
2016-03-08 23:02 ` Duy Nguyen [this message]
2016-03-10 12:20 ` Duy Nguyen
2016-03-10 21:10 ` Jeff King
2016-03-10 21:26 ` Junio C Hamano
2016-03-10 21:40 ` Jeff King
2016-03-11 0:47 ` Duy Nguyen
2016-03-11 16:53 ` Junio C Hamano
2016-03-11 18:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8BFK64rzJwQxB8M3=uA_g9s6N70vjNyLOnroZc28soiAQ@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).