git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Ed Avis <eda@waniasset.com>, Git List <git@vger.kernel.org>
Subject: Re: Log messages beginning # and git rebase -i
Date: Tue, 28 Jul 2015 07:53:55 +0700	[thread overview]
Message-ID: <CACsJy8BE8GOj6g-pH7UgQ6sEQk_ZbtgqHkAHQvTkCDJU=2dBYw@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cRT6=YCHz+phfE+84y27ey-6ScjPxP2cHiVqumJmR6mOw@mail.gmail.com>

On Tue, Jul 28, 2015 at 6:25 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Mon, Jul 27, 2015 at 7:38 AM, Ed Avis <eda@waniasset.com> wrote:
>> git commit will happily let you specify log messages beginning with #.
>> But then on git rebase -i, when squashing some commits, the editing for the
>> combined log message treats lines beginning with # as comments.  This means
>> that if you are not careful the commit message can get lost on rebasing.
>>
>> I suggest that git rebase should add an extra space at the start of existing
>> log message lines which begin with #.  That is a bit of a kludge but it is
>> better than losing them because they got mixed up with comments.
>
> 'git rebase --interactive' respects the core.commentChar configuration
> variable, which you can set to some value other than '#'.

Yeah. I recommend setting it to 'auto' so it will pick an unused
character as separator (most of the time, don't push it too hard)
-- 
Duy

  reply	other threads:[~2015-07-28  0:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 11:38 Log messages beginning # and git rebase -i Ed Avis
2015-07-27 23:25 ` Eric Sunshine
2015-07-28  0:53   ` Duy Nguyen [this message]
2015-07-28  9:51   ` Ed Avis
2015-07-28 15:25     ` Matthieu Moy
2015-07-28 16:30       ` Junio C Hamano
2015-07-28 16:40         ` Ed Avis
2015-07-28 17:48         ` Matthieu Moy
2015-07-28 18:44           ` Junio C Hamano
2015-07-29 10:17             ` Matthieu Moy
2015-07-29 10:19               ` Ed Avis
2019-04-22 10:05             ` [PATCH] allow commentChars in commit messages Corentin BOMPARD
2015-07-29 10:47           ` Log messages beginning # and git rebase -i Duy Nguyen
2015-07-29 12:17             ` Matthieu Moy
2015-07-29 12:47               ` Duy Nguyen
2015-07-29 15:54               ` Junio C Hamano
2015-07-29 16:03                 ` Matthieu Moy
2015-07-29 17:02                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8BE8GOj6g-pH7UgQ6sEQk_ZbtgqHkAHQvTkCDJU=2dBYw@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=eda@waniasset.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).