git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: ab/* topics
Date: Thu, 1 Nov 2018 16:32:43 +0100	[thread overview]
Message-ID: <CACsJy8B4KtVHkFPKzt66JzfTp1sOL=MKNGdJuWW45vX1ht2PqA@mail.gmail.com> (raw)
In-Reply-To: <xmqq8t2dsz8x.fsf@gitster-ct.c.googlers.com>

On Thu, Nov 1, 2018 at 3:04 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
> > Could you please pick up
> > https://public-inbox.org/git/20181024114725.3927-1-avarab@gmail.com/ ?
> > It seems to have fallen between the cracks and addressed the feedback on
> > v1, and looks good to me (and nobody's objected so far...).
>
> If this is the runtime-gettext-poison thing, this did not fall thru
> the cracks---I didn't get the impression that "no objection was a
> sign of being excellent"; rather I recall feeling that you were the
> only person who were excited about it, while everybody else was
> "Meh".

I would be more excited if the scrambling patches go first (*) and
then we start to make "make test" poisoned by default. Scrambled
output is still very readable and it will make people not forget about
grepping translated stuff the wrong way. Of course *i18n* functions in
the test suite need to be updated to to grep/compare for real, not
just exit early like they do now.

(*) The pseudolocalization idea is also good, but printing unicode by
default may be a bit of a stretch. Not everybody is running the test
suite with a unicode-capable terminal.
-- 
Duy

  reply	other threads:[~2018-11-01 15:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01  9:59 What's cooking in git.git (Nov 2018, #01; Thu, 1) Junio C Hamano
2018-11-01 11:02 ` ab/* topics (was: Re: What's cooking in git.git (Nov 2018, #01; Thu, 1)) Ævar Arnfjörð Bjarmason
2018-11-01 13:10   ` SZEDER Gábor
2018-11-01 13:46     ` Ævar Arnfjörð Bjarmason
2018-11-01 14:30       ` SZEDER Gábor
2018-11-01 13:28   ` ab/* topics Junio C Hamano
2018-11-01 15:32     ` Duy Nguyen [this message]
2018-11-01 19:38       ` Ævar Arnfjörð Bjarmason
2018-11-01 16:07 ` master updated? (was Re: What's cooking in git.git (Nov 2018, #01; Thu, 1)) Derrick Stolee
2018-11-02  0:04   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8B4KtVHkFPKzt66JzfTp1sOL=MKNGdJuWW45vX1ht2PqA@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).