* [PATCH] doc: remove unneeded TODO for release_commit_memory
@ 2018-12-31 23:57 Albert Burt
2019-01-01 10:40 ` Duy Nguyen
0 siblings, 1 reply; 5+ messages in thread
From: Albert Burt @ 2018-12-31 23:57 UTC (permalink / raw)
To: git; +Cc: gitster, stefanbeller, Albert Burt
The code that was merged with commit 1102405 left in an TODO that
is no longer relevant. It seems as if we can remove this todo.
util seems to not be a field of the struct commit,
definition of struct commit --> commit.c:27
The commit list also, does not contain a field for util.
____
By making a contribution to this project, I certify that:
a. The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
b. The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
c. The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
d. I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
____
Signed-off-by: Albert Burt <aburthinds@gmail.com>
---
commit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/commit.c b/commit.c
index 2d94e0b199..2ff6dca0bc 100644
--- a/commit.c
+++ b/commit.c
@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
c->index = 0;
free_commit_buffer(c);
free_commit_list(c->parents);
- /* TODO: what about commit->util? */
-
c->object.parsed = 0;
}
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: remove unneeded TODO for release_commit_memory
2018-12-31 23:57 [PATCH] doc: remove unneeded TODO for release_commit_memory Albert Burt
@ 2019-01-01 10:40 ` Duy Nguyen
2019-01-01 20:08 ` [PATCH v2] " Albert Burt
0 siblings, 1 reply; 5+ messages in thread
From: Duy Nguyen @ 2019-01-01 10:40 UTC (permalink / raw)
To: Albert Burt; +Cc: Git Mailing List, Junio C Hamano, Stefan Beller
On Tue, Jan 1, 2019 at 7:02 AM Albert Burt <aburthinds@gmail.com> wrote:
>
> The code that was merged with commit 1102405 left in an TODO that
People usually use something this to produce the commit reference
git show -s --date=short --pretty='format:%h (%s - %ad)'
which produces
110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
> is no longer relevant. It seems as if we can remove this todo.
> util seems to not be a field of the struct commit,
> definition of struct commit --> commit.c:27
> The commit list also, does not contain a field for util.
There was commit->util, which was deleted in 9d2c97016f (commit.h:
delete 'util' field in struct commit - 2018-05-19). You can mention it
too if you reroll this patch.
> ____
> By making a contribution to this project, I certify that:
>
> a. The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license
> indicated in the file; or
>
> b. The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source
> license and I have the right under that license to submit that
> work with modifications, whether created in whole or in part
> by me, under the same open source license (unless I am
> permitted to submit under a different license), as indicated
> in the file; or
>
> c. The contribution was provided directly to me by some other
> person who certified (a), (b) or (c) and I have not modified
> it.
>
> d. I understand and agree that this project and the contribution
> are public and that a record of the contribution (including all
> personal information I submit with it, including my sign-off) is
> maintained indefinitely and may be redistributed consistent with
> this project or the open source license(s) involved.
> ____
I think you can drop this. Your S-o-b below implies all this.
> Signed-off-by: Albert Burt <aburthinds@gmail.com>
> ---
> commit.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/commit.c b/commit.c
> index 2d94e0b199..2ff6dca0bc 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
> c->index = 0;
> free_commit_buffer(c);
> free_commit_list(c->parents);
> - /* TODO: what about commit->util? */
> -
Obviously correct :)
> c->object.parsed = 0;
> }
>
> --
> 2.17.2 (Apple Git-113)
>
--
Duy
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] doc: remove unneeded TODO for release_commit_memory
2019-01-01 10:40 ` Duy Nguyen
@ 2019-01-01 20:08 ` Albert Burt
2019-01-02 11:17 ` Duy Nguyen
0 siblings, 1 reply; 5+ messages in thread
From: Albert Burt @ 2019-01-01 20:08 UTC (permalink / raw)
To: pclouds; +Cc: git, gitster, stefanbeller, Albert Burt
Remove TODO that was left in from:
commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
Todo can be removed as:
9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
deletes commit->util.
Signed-off-by: Albert Burt <aburthinds@gmail.com>
---
Thanks for looking at this for me Duy. I updated some of the changes you
suggested.
Let me know if there's anything else that I would need to clean up, or do better.
:)
commit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/commit.c b/commit.c
index 2d94e0b199..2ff6dca0bc 100644
--- a/commit.c
+++ b/commit.c
@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
c->index = 0;
free_commit_buffer(c);
free_commit_list(c->parents);
- /* TODO: what about commit->util? */
-
c->object.parsed = 0;
}
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory
2019-01-01 20:08 ` [PATCH v2] " Albert Burt
@ 2019-01-02 11:17 ` Duy Nguyen
2019-01-03 7:21 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Duy Nguyen @ 2019-01-02 11:17 UTC (permalink / raw)
To: Albert Burt; +Cc: Git Mailing List, Junio C Hamano, Stefan Beller
On Wed, Jan 2, 2019 at 3:09 AM Albert Burt <aburthinds@gmail.com> wrote:
>
> Remove TODO that was left in from:
> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
>
> Todo can be removed as:
> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
> deletes commit->util.
>
> Signed-off-by: Albert Burt <aburthinds@gmail.com>
> ---
>
> Thanks for looking at this for me Duy. I updated some of the changes you
> suggested.
>
> Let me know if there's anything else that I would need to clean up, or do better.
> :)
Nope. The patch looks good to me.
>
> commit.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/commit.c b/commit.c
> index 2d94e0b199..2ff6dca0bc 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
> c->index = 0;
> free_commit_buffer(c);
> free_commit_list(c->parents);
> - /* TODO: what about commit->util? */
> -
> c->object.parsed = 0;
> }
>
> --
> 2.17.2 (Apple Git-113)
>
--
Duy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory
2019-01-02 11:17 ` Duy Nguyen
@ 2019-01-03 7:21 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2019-01-03 7:21 UTC (permalink / raw)
To: Duy Nguyen; +Cc: Albert Burt, Git Mailing List, Stefan Beller
Duy Nguyen <pclouds@gmail.com> writes:
> On Wed, Jan 2, 2019 at 3:09 AM Albert Burt <aburthinds@gmail.com> wrote:
>>
>> Remove TODO that was left in from:
>> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
>>
>> Todo can be removed as:
>> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
>> deletes commit->util.
>>
>> Signed-off-by: Albert Burt <aburthinds@gmail.com>
>> ---
>>
>> Thanks for looking at this for me Duy. I updated some of the changes you
>> suggested.
>>
>> Let me know if there's anything else that I would need to clean up, or do better.
>> :)
>
> Nope. The patch looks good to me.
Yes, but we'll fix this with 6a7895fd ("commit: prepare
free_commit_buffer and release_commit_memory for any repo",
2018-12-14) anyway, so I am not sure if this is worth pursuing
separately.
>
>>
>> commit.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/commit.c b/commit.c
>> index 2d94e0b199..2ff6dca0bc 100644
>> --- a/commit.c
>> +++ b/commit.c
>> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
>> c->index = 0;
>> free_commit_buffer(c);
>> free_commit_list(c->parents);
>> - /* TODO: what about commit->util? */
>> -
>> c->object.parsed = 0;
>> }
>>
>> --
>> 2.17.2 (Apple Git-113)
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-03 7:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 23:57 [PATCH] doc: remove unneeded TODO for release_commit_memory Albert Burt
2019-01-01 10:40 ` Duy Nguyen
2019-01-01 20:08 ` [PATCH v2] " Albert Burt
2019-01-02 11:17 ` Duy Nguyen
2019-01-03 7:21 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).