From: Duy Nguyen <pclouds@gmail.com>
To: daniels@umanovskis.se
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] doc: move git-cherry to plumbing
Date: Thu, 1 Nov 2018 18:13:00 +0100 [thread overview]
Message-ID: <CACsJy8AVGbS_NTZsUj_hD9D+t4YV1_S4KTD25Kda85syvoowyg@mail.gmail.com> (raw)
In-Reply-To: <20181011183350.14584-1-daniels@umanovskis.se>
On Thu, Oct 11, 2018 at 9:38 PM Daniels Umanovskis
<daniels@umanovskis.se> wrote:
>
> Also remove git-cherry from Bash completion because plumbing
> commands do not belong there.
Er.. why?
>
> Signed-off-by: Daniels Umanovskis <daniels@umanovskis.se>
> ---
>
> Up to discussion whether cherry should be considered plumbing.
> I lean towards considering it a rarely-used porcelain command, but
> a case could be made either way so let's see what the list thinks.
>
> command-list.txt | 2 +-
> contrib/completion/git-completion.bash | 11 -----------
> 2 files changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/command-list.txt b/command-list.txt
> index c36ea3c18..bdca6e3d3 100644
> --- a/command-list.txt
> +++ b/command-list.txt
> @@ -62,7 +62,7 @@ git-check-mailmap purehelpers
> git-checkout mainporcelain history
> git-checkout-index plumbingmanipulators
> git-check-ref-format purehelpers
> -git-cherry ancillaryinterrogators complete
> +git-cherry plumbinginterrogators complete
> git-cherry-pick mainporcelain
> git-citool mainporcelain
> git-clean mainporcelain
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d63d2dffd..12f7ce0c5 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1340,17 +1340,6 @@ _git_checkout ()
> esac
> }
>
> -_git_cherry ()
> -{
> - case "$cur" in
> - --*)
> - __gitcomp_builtin cherry
> - return
> - esac
> -
> - __git_complete_refs
I think this is a regression. Because now "git cherry <tab>" will not
complete refs (the default completer can still complete "git cherry
--<tab>" fine). We support option completion of all commands no matter
what categeory they are. The category is mostly to hide them from "git
<tab>".
If you just want to hide "git cherry" from the "git <tab>" list, then
you could remove the "complete" tag in command-list.txt above.
> -}
> -
> __git_cherry_pick_inprogress_options="--continue --quit --abort"
>
> _git_cherry_pick ()
> --
> 2.19.1.330.g93276587c.dirty
>
--
Duy
prev parent reply other threads:[~2018-11-01 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 18:33 [PATCH] doc: move git-cherry to plumbing Daniels Umanovskis
2018-11-01 17:13 ` Duy Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8AVGbS_NTZsUj_hD9D+t4YV1_S4KTD25Kda85syvoowyg@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=daniels@umanovskis.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).