From: Duy Nguyen <pclouds@gmail.com>
To: Stefan Zager <szager@google.com>
Cc: Zachary Turner <zturner@chromium.org>,
Karsten Blees <karsten.blees@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Make the git codebase thread-safe
Date: Sat, 15 Feb 2014 07:56:00 +0700 [thread overview]
Message-ID: <CACsJy8AQNmmW40R-H7kz1dmwiaSKVgu+GP=Jt1qTKgfbZoMkMA@mail.gmail.com> (raw)
In-Reply-To: <CAHOQ7J-gGbnADQ+3TGy6b6LJSLH8jvAbdTrc20Ybh=p0D2FmsQ@mail.gmail.com>
On Sat, Feb 15, 2014 at 7:50 AM, Stefan Zager <szager@google.com> wrote:
> On Fri, Feb 14, 2014 at 4:45 PM, Duy Nguyen <pclouds@gmail.com> wrote:
>> On Sat, Feb 15, 2014 at 2:16 AM, Zachary Turner <zturner@chromium.org> wrote:
>>> (Gah, sorry if you're receiving multiple emails to your personal
>>> addresses, I need to get used to manually setting Plain-text mode
>>> every time I send a message).
>>>
>>> For the mixed read, we wouldn't be looking for another caller of
>>> pread() (since it doesn't care what the file pointer is), but instead
>>> a caller of read() or lseek() (since those do depend on the current
>>> file pointer). In index-pack.c, I see two possible culprits:
>>>
>>> 1) A call to xread() from inside fill()
>>> 2) A call to lseek in parse_pack_objects()
>>>
>>> Do you think these could be related? If so, maybe that opens up some
>>> other solutions?
>>
>> For index-pack alone, what's wrong with open one file handle per thread?
>
> Nothing wrong with that, except that it would mean either using
> thread-local storage (which the code doesn't currently use); or
> plumbing pack_fd through the call stack, which doesn't sound very fun.
Current code does use thread-local storage (struct thread_local and
get_thread_data). Adding a new file handle when NO_THREAD_SAFE_PREAD
is defined is simpler imo.
--
Duy
next prev parent reply other threads:[~2014-02-15 0:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 1:54 Make the git codebase thread-safe Stefan Zager
2014-02-12 2:02 ` Robin H. Johnson
2014-02-12 3:43 ` Duy Nguyen
2014-02-12 11:00 ` Karsten Blees
2014-02-12 23:03 ` Mike Hommey
2014-02-13 0:06 ` Karsten Blees
2014-02-12 18:15 ` Stefan Zager
2014-02-12 2:11 ` Duy Nguyen
2014-02-12 18:12 ` Stefan Zager
2014-02-12 18:33 ` Matthieu Moy
2014-02-12 18:39 ` Stefan Zager
2014-02-12 18:50 ` David Kastrup
2014-02-12 19:02 ` Stefan Zager
2014-02-12 19:15 ` David Kastrup
2014-02-12 23:09 ` Mike Hommey
2014-02-13 6:04 ` David Kastrup
2014-02-13 9:34 ` Mike Hommey
2014-02-13 9:48 ` Mike Hommey
2014-02-13 8:30 ` David Kastrup
2014-02-12 20:06 ` Junio C Hamano
2014-02-12 20:27 ` Stefan Zager
2014-02-12 23:05 ` Junio C Hamano
2014-02-12 11:59 ` Erik Faye-Lund
2014-02-12 18:20 ` Stefan Zager
2014-02-12 18:27 ` Erik Faye-Lund
2014-02-12 18:34 ` Stefan Zager
2014-02-12 18:37 ` Erik Faye-Lund
2014-02-12 19:22 ` Karsten Blees
2014-02-12 19:30 ` Stefan Zager
2014-02-13 8:27 ` Johannes Sixt
2014-02-13 8:38 ` David Kastrup
2014-02-13 18:40 ` Stefan Zager
2014-02-13 18:38 ` Zachary Turner
2014-02-13 22:51 ` Karsten Blees
2014-02-13 22:53 ` Stefan Zager
2014-02-13 23:09 ` Zachary Turner
2014-02-14 19:04 ` Karsten Blees
[not found] ` <CAAErz9g7ND1htfk=yxRJJLbSEgBi4EV_AHC9uDRptugGWFWcXw@mail.gmail.com>
2014-02-14 19:16 ` Zachary Turner
2014-02-14 23:10 ` Karsten Blees
2014-02-15 0:45 ` Duy Nguyen
2014-02-15 0:50 ` Stefan Zager
2014-02-15 0:56 ` Duy Nguyen [this message]
2014-02-15 1:15 ` Zachary Turner
2014-02-15 1:39 ` Duy Nguyen
2014-02-18 17:55 ` Junio C Hamano
2014-02-18 18:14 ` Zachary Turner
2014-02-14 19:52 ` Stefan Zager
2014-02-14 21:49 ` Stefan Zager
2014-02-13 1:42 ` brian m. carlson
2019-04-02 0:52 ` Matheus Tavares
2019-04-02 1:07 ` Duy Nguyen
2019-04-02 10:30 ` David Kastrup
2019-04-02 11:35 ` Duy Nguyen
2019-04-02 11:52 ` David Kastrup
2019-04-02 19:06 ` Matheus Tavares Bernardino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8AQNmmW40R-H7kz1dmwiaSKVgu+GP=Jt1qTKgfbZoMkMA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
--cc=szager@google.com \
--cc=zturner@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).