From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <junio@pobox.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] format-patch: notice failure to open cover letter for writing
Date: Fri, 22 Feb 2019 14:50:49 +0700 [thread overview]
Message-ID: <CACsJy8A1cqWkomePW8i6veNT+WP2nq_kAZHay74ZgZFsz-d+nw@mail.gmail.com> (raw)
In-Reply-To: <20190222062606.GD10248@sigill.intra.peff.net>
On Fri, Feb 22, 2019 at 1:28 PM Jeff King <peff@peff.net> wrote:
> > diff --git a/builtin/log.c b/builtin/log.c
> > index 3e145fe502..43fc9a07df 100644
> > --- a/builtin/log.c
> > +++ b/builtin/log.c
> > @@ -1047,7 +1047,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
> >
> > if (!use_stdout &&
> > open_next_file(NULL, rev->numbered_files ? NULL : "cover-letter", rev, quiet))
> > - return;
> > + die(_("Failed to create cover-letter file"));
>
> I'd suggest s/F/f/ in the message to match our usual style, though I see
> this code has a lot of capitalized errors already. :)
Thanks! The lowercase wins over uppercase [1] 1517 to 327.
Unfortunately it's a tie in this file. But I think it's still good
that new messages stick to lowercase.
[1] counting error/warn/die only with
git grep 'die[_a-z]*(_("[A-Z]\|error[_a-z]*(_("[A-Z]\|warning[_a-z]*(_("[A-Z]'
-- \*.c
--
Duy
next prev parent reply other threads:[~2019-02-22 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 23:50 [PATCH] format-patch: notice failure to open cover letter for writing Junio C Hamano
2019-02-22 6:26 ` Jeff King
2019-02-22 7:50 ` Duy Nguyen [this message]
2019-02-22 17:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8A1cqWkomePW8i6veNT+WP2nq_kAZHay74ZgZFsz-d+nw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).