From: Duy Nguyen <pclouds@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Stefan Zager" <szager@chromium.org>,
"Torsten Bögershausen" <tboegi@web.de>
Subject: Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)
Date: Tue, 8 Apr 2014 07:39:00 +0700 [thread overview]
Message-ID: <CACsJy8A0oNRZ45xLvGTDPmDu0ZEAyHbdQBt2gdyo1yUtUeeB_g@mail.gmail.com> (raw)
In-Reply-To: <5342EFD4.6020007@kdbg.org>
On Tue, Apr 8, 2014 at 1:35 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> Am 05.04.2014 11:19, schrieb Johannes Sixt:
>> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>> - Enable index-pack threading in msysgit.
>>>
>>> What is the status of this topic? A failure report exists
>>> ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>> where the discussion stalled. Is everybody waiting for everybody
>>> else to get the discussion unstuck?
>>
>> I still have to cross-check Duy's patch. I'll hopefully get to it in the
>> next days and report back.
>
> The test suite passes with Duy's patch ($gmane/245034), but t5302 fails
> with this patch with a MinGW build.
Is "this patch" the one on 'pu', or mine?
> The patches touch the Cygwin configuration, but I cannot test a Cygwin build.
If no one can test the Cygwin changes, I'm happy to revert it back for safety.
> I have, however, lost track of what the objective of these patches is.
> Is the threaded version significantly faster, and these patches are
> worth it?
It depends on the repo, how much deltas it has, how deep. According to
b8a2486 (index-pack: support multithreaded delta resolving -
2012-05-06), going to two cores saves ~20% time. But some actual
numbers on Windows would be nice.
--
Duy
next prev parent reply other threads:[~2014-04-08 0:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 20:58 What's cooking in git.git (Apr 2014, #01; Fri, 4) Junio C Hamano
2014-04-05 9:19 ` Johannes Sixt
2014-04-05 11:56 ` Torsten Bögershausen
2014-04-07 16:40 ` Junio C Hamano
2014-04-07 18:35 ` Johannes Sixt
2014-04-07 19:42 ` Ramsay Jones
2014-04-08 9:03 ` Torsten Bögershausen
2014-04-08 0:39 ` Duy Nguyen [this message]
2014-04-08 13:13 ` Johannes Sixt
2014-04-08 16:26 ` Junio C Hamano
2014-04-06 22:41 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8A0oNRZ45xLvGTDPmDu0ZEAyHbdQBt2gdyo1yUtUeeB_g@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=szager@chromium.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).