From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 45DDE1F45E for ; Mon, 17 Feb 2020 10:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729055AbgBQKDb (ORCPT ); Mon, 17 Feb 2020 05:03:31 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:34567 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728833AbgBQKDb (ORCPT ); Mon, 17 Feb 2020 05:03:31 -0500 Received: by mail-ed1-f68.google.com with SMTP id r18so20011663edl.1 for ; Mon, 17 Feb 2020 02:03:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nwgaElpsEm41N39jklx69Feqkx99/75kWUxz3bT9tEU=; b=gl8OkWvmr4GLxV5PegaEEqOuzB+cSc1F6Vxb3bZlEcl/fdlNz/fQ9frNHmHLveQ1zA KmIZYj0RS0aY+SoNRZpnCi1lsiKD+/2RU7Y5FJTjcDwci+6cTy7abWmqQXlqM5JNR5nk ryz8GIlP1isCra1aMn40A+sc/Ab5OhrJTGia4zAYznIA5eK/bvYwc4kqWRmra7WZsBG1 2WK/G+iWaan0IGjfkRhgRC+q3g/LOoviif4ChZbJC4OVMa3m/c7aaZDsWjObaUosb9eM PEx1YJitMxeML+wQhlEHetDfM3ynmVPgcEPfAQSvLhqcgbABSswpZmmN20swlIurpIMt HLcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nwgaElpsEm41N39jklx69Feqkx99/75kWUxz3bT9tEU=; b=pXEq/Z8D+uANqMlDWD90CZZOjhn6tg7tfKx9eiwmRIBV9xi8a0kZuh11qgwIB8lJC7 fuVOuxlO+iK11m3zR28wxF5+MJDR6356zeuZIUbA1HNn1r847ZUGEYtMoUSytLK6J9iq ue/K70ivResxB4TJzdFDBRRp0mR/vvX/8Oatg65gfvXSVRtPSWjcX+o0ckG3Rg3nlcJe tecbpUlxvraOBJ4EBEpmZt/2i45rAquQlMFBUSvc0w6MJzRy7PzFXXFkVA4AsHpoRz1B Wc12Ca1D9fG943pn8gzbE/Fj1TSdmehlA9EKg2k5km2Q0pab63fhLKeX5iogaMojS/ZJ jorg== X-Gm-Message-State: APjAAAVpKGAbIJO3XnXBx9QzGbrWXmNK8E1e7MvMDm044B8bJ1Ha/Bfr MdJDFIn5940sT0Y6tA3PJYA1RRdKVCD6SqHh9n6gnRE3H9w= X-Google-Smtp-Source: APXvYqzTimdWNFgDtmN3ipfnvsbTcGMJdqf1dTCoV0Wble3d14dTsX6AqhBWx+egkzn6LZalFjHz6WFv04Ui+KI75Y4= X-Received: by 2002:a17:906:22cf:: with SMTP id q15mr13771978eja.77.1581933809311; Mon, 17 Feb 2020 02:03:29 -0800 (PST) MIME-Version: 1.0 References: <080d12b5c696d61ac1052d5863f7260a4005346e.1581889150.git.gitgitgadget@gmail.com> In-Reply-To: From: Heba Waly Date: Mon, 17 Feb 2020 23:03:18 +1300 Message-ID: Subject: Re: [PATCH v2 1/2] advice: refactor advise API To: Junio C Hamano Cc: Heba Waly via GitGitGadget , Git Mailing List Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Feb 17, 2020 at 4:28 PM Junio C Hamano wrote: > >And I see that now you are going all the way to discard the >string-based keys to enumeration, I think this deserves to be called >"revamp advise API". Fair enough. > There seem to be a handful of lines with trailing whitespaces. I > think I've fixed them all on the receiving end, but please proofread > before you come up with the next round. > Sorry about that, I fixed this setting in my IDE a while ago but looks like it has a bug. Will keep an eye on it in the future, thanks > Thanks. Heba