From: Josh Soref <jsoref@gmail.com>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org, phillip.wood@dunelm.org.uk
Subject: Re: [PATCH 4/8] SubmittingPatches: update extra tags list
Date: Wed, 20 Dec 2023 12:42:44 -0500 [thread overview]
Message-ID: <CACZqfqCar=tay5diocU7jVWBwPUFqewNYfPLHkYvvR1fSBSdPA@mail.gmail.com> (raw)
In-Reply-To: <CABPp-BFjotLN4sCe+6uHAU7qhr1COM0B4EdW0f0-X-xf5qXinA@mail.gmail.com>
Elijah Newren wrote:
> Yeah, well it appears that those of us who have been here in Rome for
> a while aren't a fan of it anymore either; see also Junio's response
> in this thread about that.
Right.
> [Josh Soref <jsoref@gmail.com> wrote:]
> > Given that Noticed-by is more common than Co-authored-by, I have a
> > hard time arguing that it shouldn't be included.
>
> Not if you look at the last three years; there Co-authored-by is more
> than 17 times more common than Noticed-by.
> Given the large drop-off in usage of the Noticed-by trailer, I'd
> suggest just leaving it out.
> Perhaps replace
>
> You can also create your own tag or use one that's in common usage
> such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".
>
> with
>
> While you can also create your own trailer if the situation warrants it, we
> encourage you to instead use one of the common trailers in this project
> highlighted above.
>
> ?
Let's have some fun (inception):
commit eac2211332f754c5f4127a58aafb9882bfe939e8
Author: Josh Soref <jsoref@gmail.com>
Date: Wed Dec 20 12:34:54 2023 -0500
SubmittingPatches: discourage new trailers
There seems to be consensus amongst the core Git community on a working
set of common trailers, and there are non-trivial costs to people
inventing new trailers (research to discover what they mean/how they
differ from existing trailers) such that inventing new ones is generally
unwarranted and not something to be recommended to new contributors.
Suggested-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 32e9023877..58dfe40504 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -358,4 +358,5 @@ If you like, you can put extra tags at the end:
-You can also create your own tag or use one that's in common usage
-such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".
+While you can also create your own trailer if the situation warrants it, we
+encourage you to instead use one of the common trailers in this project
+highlighted above.
next prev parent reply other threads:[~2023-12-20 17:43 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 8:41 [PATCH 0/8] Minor improvements to CodingGuidelines and SubmittingPatches Josh Soref via GitGitGadget
2023-12-19 8:41 ` [PATCH 1/8] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-19 8:41 ` [PATCH 2/8] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-19 8:41 ` [PATCH 3/8] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-19 8:41 ` [PATCH 4/8] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-20 15:18 ` Phillip Wood
2023-12-20 15:30 ` Elijah Newren
2023-12-20 16:09 ` Josh Soref
2023-12-20 16:49 ` Elijah Newren
2023-12-20 17:42 ` Josh Soref [this message]
2023-12-21 15:09 ` phillip.wood123
2023-12-20 16:31 ` Junio C Hamano
2023-12-19 8:41 ` [PATCH 5/8] SubmittingPatches: improve extra tags advice Josh Soref via GitGitGadget
2023-12-19 8:41 ` [PATCH 6/8] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-19 14:44 ` René Scharfe
2023-12-20 15:40 ` Elijah Newren
2023-12-20 16:25 ` Josh Soref
2023-12-20 16:39 ` Junio C Hamano
2023-12-19 8:41 ` [PATCH 7/8] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-20 15:21 ` Elijah Newren
2023-12-20 16:16 ` Josh Soref
2023-12-20 17:00 ` Elijah Newren
2023-12-19 8:41 ` [PATCH 8/8] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget
2023-12-20 15:43 ` [PATCH 0/8] Minor improvements to CodingGuidelines and SubmittingPatches Elijah Newren
2023-12-21 16:40 ` [PATCH v2 0/9] " Josh Soref via GitGitGadget
2023-12-21 16:40 ` [PATCH v2 1/9] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-21 21:03 ` Junio C Hamano
2023-12-21 21:52 ` Josh Soref
2023-12-22 1:30 ` Dragan Simic
2023-12-21 16:40 ` [PATCH v2 2/9] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-21 20:57 ` Junio C Hamano
2023-12-21 21:46 ` Josh Soref
2023-12-21 21:57 ` Junio C Hamano
2023-12-21 16:40 ` [PATCH v2 3/9] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-21 21:09 ` Junio C Hamano
2023-12-21 16:41 ` [PATCH v2 4/9] SubmittingPatches: discourage new trailers Josh Soref via GitGitGadget
2023-12-21 16:41 ` [PATCH v2 5/9] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-21 21:16 ` Junio C Hamano
2023-12-21 21:55 ` Josh Soref
2023-12-21 16:41 ` [PATCH v2 6/9] SubmittingPatches: improve extra tags advice Josh Soref via GitGitGadget
2023-12-21 21:18 ` Junio C Hamano
2023-12-21 16:41 ` [PATCH v2 7/9] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-21 21:27 ` Junio C Hamano
2023-12-21 16:41 ` [PATCH v2 8/9] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-21 16:41 ` [PATCH v2 9/9] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 0/9] Minor improvements to CodingGuidelines and SubmittingPatches Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 1/9] CodingGuidelines: move period inside parentheses Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 2/9] CodingGuidelines: write punctuation marks Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 3/9] SubmittingPatches: drop ref to "What's in git.git" Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 4/9] SubmittingPatches: discourage new trailers Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 5/9] SubmittingPatches: update extra tags list Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 6/9] SubmittingPatches: provide tag naming advice Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 7/9] SubmittingPatches: clarify GitHub visual Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 8/9] SubmittingPatches: clarify GitHub artifact format Josh Soref via GitGitGadget
2023-12-28 4:55 ` [PATCH v3 9/9] SubmittingPatches: hyphenate non-ASCII Josh Soref via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZqfqCar=tay5diocU7jVWBwPUFqewNYfPLHkYvvR1fSBSdPA@mail.gmail.com' \
--to=jsoref@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).