git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Rafael Ascensão" <rafa.almas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Daniels Umanovskis <daniels@umanovskis.se>,
	Jeff King <peff@peff.net>
Subject: Re: What's cooking in git.git (Feb 2019, #02; Wed, 6)
Date: Mon, 11 Feb 2019 23:40:08 +0000	[thread overview]
Message-ID: <CACUQV58vvDzhqRrtutZMDV_Kkz137oP6rLUODaniMekfGa5gyQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqimxwqcqw.fsf@gitster-ct.c.googlers.com>

On Thu, Feb 7, 2019 at 7:28 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> * du/branch-show-current (2018-10-26) 1 commit - branch: introduce
> --show-current display option
>
>  "git branch" learned a new subcommand "--show-current".
>
>  Will merge to 'next'.
>

Did something change? I may have missed it. Until last what's cooking, this was
marked with:

On Tue, Feb 5, 2019 at 11:56 PM Junio C Hamano <gitster@pobox.com> wrote:
>
>  I am personally not yet quite convinced if this is worth pursuing.
>

I also suggested a different implementation which simplifies it and should
remove some unreachable checks that can be seen in "Git Test Coverage Report
(Wednesday, Feb. 6)"
https://public-inbox.org/git/20181107225619.6683-1-rafa.almas@gmail.com/

I was expecting Daniels to squash these changes into his patch or for it to be
dropped in favor of something else. For example adding `--list-head` instead,
as discussed in early versions of this patch.
https://public-inbox.org/git/20181011223457.GB7131@rigel/

Cheers,
Rafael Ascensão

  reply	other threads:[~2019-02-11 23:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07  7:27 What's cooking in git.git (Feb 2019, #02; Wed, 6) Junio C Hamano
2019-02-11 23:40 ` Rafael Ascensão [this message]
2019-02-12  3:10   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACUQV58vvDzhqRrtutZMDV_Kkz137oP6rLUODaniMekfGa5gyQ@mail.gmail.com \
    --to=rafa.almas@gmail.com \
    --cc=daniels@umanovskis.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).