From: "Rafael Ascensão" <rafa.almas@gmail.com>
To: martin.agren@gmail.com
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
David Turner <dturner@twopensource.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: git update-ref fails to create reference. (bug)
Date: Sat, 05 May 2018 19:08:01 +0000 [thread overview]
Message-ID: <CACUQV5-9PagVhE5YY=Z3721YRiBwSZykT3ZjtzmD3o-c6O6ddQ@mail.gmail.com> (raw)
In-Reply-To: <20180504182646.7738-1-martin.agren@gmail.com>
Thanks Martin for the quick fix.
On Fri, May 04, 2018 at 08:26:46PM +0200, Martin �gren wrote:
> Anyway, that's not where I'm stuck... Regardless of how I try to write
> tests (in t1400), they just pass beautifully even before this patch. I
> might be able to look into that more on the weekend. If anyone has
> ideas, I am all ears. Or if someone feels like picking this up and
> running with it, feel free.
In t1400 `m=refs/heads/master` is used in the majority of tests. And
this issue doesn't manifest itself if refs are being written under refs/
It also seems particular about having the "old sha" set to 40 zeros or
the empty string.
So I guess we should add some extra tests to cover the variations of
these two cases.
e.g.
test_expect_success "create PSEUDOREF" '
git update-ref PSEUDOREF $A
0000000000000000000000000000000000000000 &&
test $A = $(cat .git/PSEUDOREF)
'
fails/succeeds appropriately in my limited testing.
I am busy this weekend, but can try to write some if no one writes it
until after the weekend.
Cumprimentos,
Rafael Ascensão
next prev parent reply other threads:[~2018-05-05 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 16:28 git update-ref fails to create reference. (bug) Rafael Ascensão
2018-05-04 18:26 ` Martin Ågren
2018-05-05 19:08 ` Rafael Ascensão [this message]
2018-05-06 13:35 ` [PATCH] refs: handle null-oid for pseudorefs Martin Ågren
2018-05-06 15:37 ` David Turner
2018-05-07 7:39 ` Michael Haggerty
2018-05-07 10:05 ` Martin Ågren
2018-05-10 19:29 ` [PATCH v2 0/3] refs: handle zero oid " Martin Ågren
2018-05-10 19:29 ` [PATCH v2 1/3] refs.c: refer to "object ID", not "sha1", in error messages Martin Ågren
2018-05-10 19:29 ` [PATCH v2 2/3] t1400: add tests around adding/deleting pseudorefs Martin Ågren
2018-05-10 19:29 ` [PATCH v2 3/3] refs: handle zero oid for pseudorefs Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACUQV5-9PagVhE5YY=Z3721YRiBwSZykT3ZjtzmD3o-c6O6ddQ@mail.gmail.com' \
--to=rafa.almas@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martin.agren@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).