From: Paul Tan <pyokagan@gmail.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Stefan Beller <sbeller@google.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] t4150: fix broken test for am --scissors
Date: Tue, 7 Aug 2018 18:53:44 +0800 [thread overview]
Message-ID: <CACRoPnSJm4bwRs-k5kkz4VDMCQ_r00JhQxpXUTrFUvRVODMWHg@mail.gmail.com> (raw)
In-Reply-To: <a50da318-1f15-3dc8-53e0-c40365a053f7@gmail.com>
On Tue, Aug 7, 2018 at 1:42 AM, Andrei Rybak <rybak.a.v@gmail.com> wrote:
> On 2018-08-06 10:58, Paul Tan wrote:
>>> + git commit -F msg-without-scissors-line &&
>>> + git tag scissors-used &&
>>
>> Nit: I'm not quite sure about naming the tag "scissors-used" though,
>> since this commit was not created from the output of "git am
>> --scissors". Maybe it should be named `commit-without-scissors-line`
>> or something?
>>
>>> + git commit -F msg-with-scissors-line &&
>>> + git tag scissors-not-used &&
>>
>> Nit: Likewise, perhaps this tag could be named `commit-with-scissors-line`?
>
> How about "expected-for-scissors" and "expected-for-no-scissors"?
Yep that's fine.
Thanks,
Paul
next prev parent reply other threads:[~2018-08-07 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 13:38 [RFC] broken test for git am --scissors Andrei Rybak
2018-08-03 22:39 ` [PATCH] t4150: fix broken test for " Andrei Rybak
2018-08-03 23:04 ` Junio C Hamano
2018-08-04 0:39 ` Andrei Rybak
2018-08-04 18:10 ` [PATCH v2] " Andrei Rybak
2018-08-06 8:58 ` Paul Tan
2018-08-06 15:04 ` Junio C Hamano
2018-08-06 17:42 ` Andrei Rybak
2018-08-07 10:53 ` Paul Tan [this message]
2018-08-06 17:49 ` [PATCH v3] " Andrei Rybak
2018-08-06 20:14 ` Junio C Hamano
2018-08-07 11:24 ` Andrei Rybak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRoPnSJm4bwRs-k5kkz4VDMCQ_r00JhQxpXUTrFUvRVODMWHg@mail.gmail.com \
--to=pyokagan@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=rybak.a.v@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).