From: Paul Tan <pyokagan@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Stefan Beller" <sbeller@google.com>,
"Lukas Sandström" <luksan@gmail.com>,
"Paul Tan" <pyokagan@gmail.com>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] Revert "git am/mailinfo: Don't look at in-body headers when rebasing"
Date: Wed, 24 Jun 2015 18:36:07 +0800 [thread overview]
Message-ID: <CACRoPnRFCZWih-uFMRnqWwOCmeM9=RgUUpQURk4vrZZsDOjGvg@mail.gmail.com> (raw)
In-Reply-To: <1434445392-6265-1-git-send-email-pyokagan@gmail.com>
Hi Junio,
On Tue, Jun 16, 2015 at 5:03 PM, Paul Tan <pyokagan@gmail.com> wrote:
> This reverts commit d25e51596be9271ad833805a3d6f9012dc24ee79, removing
> git-mailsplit's --no-inbody-headers option.
>
> While --no-inbody-headers was introduced to prevent commit messages from
> being munged by git-mailinfo while rebasing, the need for this option
> disappeared since 5e835ca (rebase: do not munge commit log message,
> 2008-04-16), as git-am bypasses git-mailinfo and gets the commit message
> directly from the commit ID in the patch.
>
> git-am is the only user of --no-inbody-headers, and this option is not
> documented. As such, it should be removed.
>
> Signed-off-by: Paul Tan <pyokagan@gmail.com>
What do you think about applying this patch?
Either way, the no-inbody-headers code in git-am.sh is dead code so I
don't think I will be implementing it in the git-am rewrite.
Thanks,
Paul
next prev parent reply other threads:[~2015-06-24 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 9:03 [PATCH/RFC] Revert "git am/mailinfo: Don't look at in-body headers when rebasing" Paul Tan
2015-06-16 9:47 ` Johannes Schindelin
2015-06-24 10:36 ` Paul Tan [this message]
2015-06-24 16:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRoPnRFCZWih-uFMRnqWwOCmeM9=RgUUpQURk4vrZZsDOjGvg@mail.gmail.com' \
--to=pyokagan@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=luksan@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).