From: Gennady Uraltsev <gennady.uraltsev@gmail.com>
To: git@vger.kernel.org
Subject: Git credential store conflicting configuration leads to unexpected behavior
Date: Tue, 6 Dec 2022 17:05:22 -0500 [thread overview]
Message-ID: <CACH4KQSutGnoyFGP2RmkwQT3yhnEg1RcvedXVSMOVVDAnz_aFg@mail.gmail.com> (raw)
Hello everyone,
I have an issue with git credential-store. In my global configuration
dir (.config/git/config) I had the line
[credential]
helper = store
while ini a repository's .git/config while I have
[credential]
helper = "store --file=./.git/git-credentials"
to store credentials "locally".
I thought the latter would overrule the former However what happens is
the following:
1) On first run the file repo-local file ./.git/git-credentials gets
created and the credentials are saved there after the user is queried
for a password
2) On subsequent runs the credentials get recovered from
./.git/git-credentials and the user is NOT asked for credentials
2b) **Here is the weird behavior** git ALSO creates the
.git-credentials file in the home directory and saves a copy of
credentials there.
The behavior 2b leads to exfiltration of passwords to a location a
user might not expect.
Workaround: Remove the line
[credential]
helper = store
in the global config.
It seems that the global config somehow does not get shadowed by the local one!
I think this is a bug with mild security implications.
Let me know.
Best,
Gennady
--
Gennady Uraltsev
<gennady.uraltsev@gmail.com>
(https://guraltsev.github.io)
next reply other threads:[~2022-12-06 22:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 22:05 Gennady Uraltsev [this message]
2022-12-06 22:16 ` Git credential store conflicting configuration leads to unexpected behavior brian m. carlson
2022-12-06 23:53 ` Gennady Uraltsev
2022-12-07 1:15 ` brian m. carlson
2022-12-07 1:19 ` Gennady Uraltsev
2022-12-07 12:01 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACH4KQSutGnoyFGP2RmkwQT3yhnEg1RcvedXVSMOVVDAnz_aFg@mail.gmail.com \
--to=gennady.uraltsev@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).