git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Jean-Noël Avila" <jn.avila@free.fr>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] l10n: add framework for localizing the manpages
Date: Wed, 15 Mar 2017 10:01:46 +0100	[thread overview]
Message-ID: <CACBZZX7CoEn0d01hU=A5RbDiNwQi0wUJM9mU25pPnqTPu05r+w@mail.gmail.com> (raw)
In-Reply-To: <103dec84-b274-0a81-fa9b-bf29afd988d9@free.fr>

On Wed, Mar 15, 2017 at 9:11 AM, Jean-Noël Avila <jn.avila@free.fr> wrote:
> Le 14/03/2017 à 22:00, Ævar Arnfjörð Bjarmason a écrit :
>> On Mon, Mar 13, 2017 at 1:01 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Jean-Noel Avila <jn.avila@free.fr> writes:
>> Jean: Comments on the patch:
>>
>> - Firstly thanks for working on this. When I hacked up the initial po
>> support in v1.7.8-rc2-1-g5e9637c629 I always meant to try out po4a,
>> but never got around to it. It's much easier than I thought.
>
> Well, that's only the simplest setup I could come up with :-). I'm
> discovering the tool and it seems that can go quite hairy, depending on
> where we want to go.
>
>> - Consider submitting a more minimal patch that doesn't have the giant
>> fr.po (or just some minor cut version) as the tip of the series, to
>> make this easier to review
>
> OK. Will split in po4a.conf + Makefile changes, then pot and po files.
> The point is that as long as the po files are not translated at a
> minimum level, po4a does not generate the target files. Right now, the
> threshold is 80% of translated strings (no fuzzy).

Right, I don't mean don't include it, just add the *.pot and *.po file
in a subsequent patch, so reviewers focusing just on the translation
infra changes have a ~100-200 line patch to look at instead of 10x
that.

>> - The git-add.txt file is hardcoded in po4a.conf, won't this file need
>> to be generated in some final version of this series?
>
> If all the translation string are harvested automatically from the
> source files, the resulting po file will be huge. For the moment, I
> prefered to manually select the files and check that po4a behaves correctly.

Yeah, makes sense, we can just start with git-add.txt and add more files later.

  reply	other threads:[~2017-03-15  9:02 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12 20:02 [PATCH] l10n: add framework for localizing the manpages Jean-Noel Avila
2017-03-12 20:02 ` Jean-Noel Avila
2017-03-12 20:36   ` Jean-Noël AVILA
2017-03-13  0:01   ` Junio C Hamano
2017-03-14 21:00     ` Ævar Arnfjörð Bjarmason
2017-03-14 21:13       ` Junio C Hamano
2017-03-15  8:11       ` Jean-Noël Avila
2017-03-15  9:01         ` Ævar Arnfjörð Bjarmason [this message]
2017-03-15  7:58     ` Jean-Noël Avila
2017-03-15 16:07       ` Junio C Hamano
2017-03-15 18:28       ` Stefan Beller
2017-03-18 17:53 ` [PATCH v2 1/2] l10n: Introduce framework for localizing man pages Jean-Noel Avila
2017-03-18 17:53   ` [PATCH v2 2/2] l10n: Add git-add.txt to localized " Jean-Noel Avila
2017-03-18 19:41   ` [PATCH v2 1/2] l10n: Introduce framework for localizing " Junio C Hamano
2017-03-18 22:17     ` Jean-Noël AVILA
2017-03-18 23:03     ` Junio C Hamano
2017-03-20  2:11       ` Junio C Hamano
2017-03-20  8:10         ` Jean-Noël Avila
2017-03-20  8:21           ` Jean-Noël AVILA
2017-03-20 16:50           ` Junio C Hamano
2017-03-20 21:02 ` Rework manpage localisation Jean-Noel Avila
2017-03-20 21:02   ` [PATCH v3 1/2] l10n: Introduce framework for localizing man pages Jean-Noel Avila
2017-03-21 18:09     ` Junio C Hamano
2017-03-20 21:02   ` [PATCH v3 2/2] l10n: Add git-add.txt to localized " Jean-Noel Avila
2017-03-20 22:05     ` Junio C Hamano
2017-03-22 12:01       ` Jean-Noël Avila
2017-03-22 18:02         ` Junio C Hamano
2017-03-22 18:41           ` Stefan Beller
2017-03-22 18:56             ` Junio C Hamano
2017-03-22 18:59               ` Stefan Beller
2017-03-24 14:21                 ` Michael J Gruber
2017-03-25 15:40           ` Jean-Noël AVILA
2017-03-26 22:56             ` Junio C Hamano
2017-03-27 20:12               ` Jean-Noël AVILA
2017-03-27 20:29                 ` Junio C Hamano
2017-03-24 15:58       ` Ævar Arnfjörð Bjarmason
2017-03-24 17:57         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACBZZX7CoEn0d01hU=A5RbDiNwQi0wUJM9mU25pPnqTPu05r+w@mail.gmail.com' \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).