git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Joel Teichroeb <joel@teichroeb.net>
Cc: Git Mailing List <git@vger.kernel.org>,
	t.gummerer@gmail.com, Jeff King <peff@peff.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v3 0/4] Implement git stash as a builtin command
Date: Sun, 28 May 2017 21:08:34 +0200	[thread overview]
Message-ID: <CACBZZX5wA57+9t+wzYc-iMpvns-zm1XAdzKszUk7PF2vkoxeMQ@mail.gmail.com> (raw)
In-Reply-To: <20170528165642.14699-1-joel@teichroeb.net>

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb <joel@teichroeb.net> wrote:
> I've rewritten git stash as a builtin c command. All tests pass,
> and I've added two new tests. Test coverage is around 95% with the
> only things missing coverage being error handlers.

Worth noting, with your patches the best of 3 run of all the stash tests:

$ for i in {1..3}; do (time prove -j1 t*-stash*.sh) 2>&1 | grep ^real;
done  |awk '{print $2}' | sort -n | head -n 1
0m3.293s

Without:

$ for i in {1..3}; do (time prove -j1 t*-stash*.sh) 2>&1 | grep ^real;
done  |awk '{print $2}' | sort -n | head -n 1
0m7.619s

Of course some individual invocations are much faster than that, this
includes all the shell overhead of the tests themselves.

  parent reply	other threads:[~2017-05-28 19:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 16:56 [PATCH v3 0/4] Implement git stash as a builtin command Joel Teichroeb
2017-05-28 16:56 ` [PATCH v3 1/4] stash: add test for stash create with no files Joel Teichroeb
2017-05-28 17:45   ` Ævar Arnfjörð Bjarmason
2017-05-29  6:35     ` Junio C Hamano
2017-05-28 16:56 ` [PATCH v3 2/4] stash: add test for stashing in a detached state Joel Teichroeb
2017-05-28 17:57   ` Ævar Arnfjörð Bjarmason
2017-05-29  6:41   ` Junio C Hamano
2017-05-28 16:56 ` [PATCH v3 3/4] close the index lock when not writing the new index Joel Teichroeb
2017-05-28 17:46   ` Ævar Arnfjörð Bjarmason
2017-05-29  6:46   ` Junio C Hamano
2017-05-28 16:56 ` [PATCH v3 4/4] stash: implement builtin stash Joel Teichroeb
2017-05-28 17:56   ` Christian Couder
2017-05-28 18:26   ` Ævar Arnfjörð Bjarmason
2017-05-28 18:31     ` Joel Teichroeb
2017-05-28 19:26       ` Jeff King
2017-05-28 18:51   ` Ævar Arnfjörð Bjarmason
2017-05-28 19:21     ` Jeff King
2017-05-29 18:18       ` Joel Teichroeb
2017-05-29 18:26         ` Ævar Arnfjörð Bjarmason
2017-06-01  3:29           ` Joel Teichroeb
2017-06-01  4:07             ` Jeff King
2017-05-29  7:16   ` Junio C Hamano
2017-05-28 19:08 ` Ævar Arnfjörð Bjarmason [this message]
2017-10-23 11:09 ` [PATCH v3 0/4] Implement git stash as a builtin command Johannes Schindelin
2017-10-23 18:35   ` Joel Teichroeb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACBZZX5wA57+9t+wzYc-iMpvns-zm1XAdzKszUk7PF2vkoxeMQ@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=joel@teichroeb.net \
    --cc=peff@peff.net \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).