From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v2 1/2] perf: add function to setup a fresh test repo
Date: Thu, 11 May 2017 11:59:01 +0200 [thread overview]
Message-ID: <CACBZZX5gXWLb4oePjC+aCRQ5HsVD8-M9Ao6akgvEKf1+gx-79A@mail.gmail.com> (raw)
In-Reply-To: <xmqq8tm3afaa.fsf@gitster.mtv.corp.google.com>
On Thu, May 11, 2017 at 11:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> On Thu, May 11, 2017 at 1:30 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>>> Hi,
>>>
>>> Ęvar Arnfjörš Bjarmason wrote:
>>>
>>> [...]
>>>> # call at least one of these to establish an appropriately-sized repository
>>>> +test_perf_fresh_repo () {
>>>> + repo="${1:-$TRASH_DIRECTORY}"
>>>> + "$MODERN_GIT" init -q "$repo" &&
>>>> + cd "$repo" &&
>>>> + test_perf_do_repo_symlink_config_
>>>> +}
>>>
>>> Unlike the other two variants, wouldn't this leave the cwd inside the
>>> new repo?
>>>
>>> In other words, I wonder if the commands starting with the 'cd' should
>>> be in a subshell.
>>>
>>> Thanks and hope that helps,
>>
>> Yup, I'll fix that. Thanks for the review & also on the other patch.
>> Will send a v3 with these issues fixed.
>
> Hmph, does v3 actually have this change?
Nope, sent v4 to fix it, sorry:
https://public-inbox.org/git/20170511094108.8756-1-avarab@gmail.com/
next prev parent reply other threads:[~2017-05-11 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 22:53 [PATCH v2 0/2] perf: show that wildmatch() regressed for pathological cases in v2.0 Ævar Arnfjörð Bjarmason
2017-05-10 22:53 ` [PATCH v2 1/2] perf: add function to setup a fresh test repo Ævar Arnfjörð Bjarmason
2017-05-10 23:30 ` Jonathan Nieder
2017-05-11 0:00 ` Ævar Arnfjörð Bjarmason
2017-05-11 0:33 ` Junio C Hamano
2017-05-11 9:55 ` Junio C Hamano
2017-05-11 9:59 ` Ævar Arnfjörð Bjarmason [this message]
2017-05-10 22:53 ` [PATCH v2 2/2] perf: add test showing exponential growth in path globbing Ævar Arnfjörð Bjarmason
2017-05-10 23:33 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACBZZX5gXWLb4oePjC+aCRQ5HsVD8-M9Ao6akgvEKf1+gx-79A@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).