From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Brandon Williams <bmwill@google.com>,
Stefan Beller <sbeller@google.com>
Subject: Re: What's cooking in git.git (May 2017, #01; Mon, 1)
Date: Tue, 2 May 2017 14:31:59 +0200 [thread overview]
Message-ID: <CACBZZX53Y50CbmkPb1USmXF4E+BzBbyo_Sr=H+Q55rujF9+ZvA@mail.gmail.com> (raw)
In-Reply-To: <xmqqr307d2jc.fsf@gitster.mtv.corp.google.com>
On Tue, May 2, 2017 at 11:35 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>>> That squash looks good to me.
>>>
>>> Thanks.
>>>
>>> That is not a particulary helpful comment, by the way. I can help
>>> topics by contributors by queuing emergency fix at the tip to make
>>> ones that do not build correctly buildable and testable (which is
>>> what the "SQUASH???" commits are about), but I'd rather not see me
>>> forced to find among 19 commits which one is broken and needs the
>>> hotfix squashed in myself.
>>
>> I'm happy to change what I'm doing to be more helpful, but it's not
>> clear to me from this & the context what that would be.
>>
>> * I sent a v4 that had this bug in <20170425210548.24612-6-avarab@gmail.com>
>> * You pointed out that initialization bug in response
>> * I sent a v5 of just that patch (not the rest of the series) in
>> response to that in <20170426074856.29903-1-avarab@gmail.com>
>> * You replied in <xmqq1sser7ty.fsf@gitster.mtv.corp.google.com> in a
>> reply I (probably mis-)read as "no worries, I'll just squash the fix
>> in"
>
> Sorry, I completely forgot about our exchange around your v5. If
> your comment were "squash is good but you've seen a replacement sent
> as v5 that is not there yet", I wouldn't have made such a silly
> comment, but given that I've already responded to your v5 saying
> I'll handle it, that is asking too much from you.
>
> What I pushed out a few hours ago should already have the fix in.
> Thanks for clarifying the situation, and sorry again.
Okey, no worries. Was just a bit confused & wondering if I could make
something easier for you in the future.
next prev parent reply other threads:[~2017-05-02 12:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 5:35 What's cooking in git.git (May 2017, #01; Mon, 1) Junio C Hamano
2017-05-01 14:25 ` Ævar Arnfjörð Bjarmason
2017-05-01 16:21 ` Brandon Williams
2017-05-01 17:44 ` Ævar Arnfjörð Bjarmason
2017-05-01 19:29 ` Jeff King
2017-05-01 23:21 ` Junio C Hamano
2017-05-02 8:23 ` Ævar Arnfjörð Bjarmason
2017-05-02 9:35 ` Junio C Hamano
2017-05-02 12:31 ` Ævar Arnfjörð Bjarmason [this message]
2017-05-02 11:11 ` Johannes Schindelin
2017-05-02 12:09 ` PCRE v2 compile error, was " Johannes Schindelin
2017-05-02 12:27 ` Ævar Arnfjörð Bjarmason
2017-05-02 16:05 ` Johannes Schindelin
2017-05-02 18:52 ` Ævar Arnfjörð Bjarmason
2017-05-02 20:51 ` Kevin Daudt
2017-05-02 21:16 ` Ævar Arnfjörð Bjarmason
2017-05-03 9:45 ` Johannes Schindelin
2017-05-03 11:15 ` Duy Nguyen
2017-05-03 15:10 ` Ævar Arnfjörð Bjarmason
2017-05-04 9:11 ` Johannes Schindelin
2017-05-04 10:24 ` Ævar Arnfjörð Bjarmason
2017-05-04 11:32 ` Johannes Schindelin
2017-05-04 11:53 ` Ævar Arnfjörð Bjarmason
2017-05-08 6:30 ` Ævar Arnfjörð Bjarmason
2017-05-08 7:10 ` Junio C Hamano
2017-05-08 23:32 ` brian m. carlson
2017-05-09 0:00 ` Ævar Arnfjörð Bjarmason
2017-05-09 0:37 ` brian m. carlson
2017-05-09 10:40 ` Johannes Schindelin
2017-05-09 11:29 ` Ævar Arnfjörð Bjarmason
2017-05-09 11:12 ` Ævar Arnfjörð Bjarmason
2017-05-09 14:22 ` demerphq
2017-05-09 14:46 ` Ævar Arnfjörð Bjarmason
2017-05-02 17:43 ` Brandon Williams
2017-05-02 17:49 ` Ævar Arnfjörð Bjarmason
2017-05-05 1:12 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACBZZX53Y50CbmkPb1USmXF4E+BzBbyo_Sr=H+Q55rujF9+ZvA@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).