From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Tom G. Christensen" <tgc@statsbiblioteket.dk>
Subject: Re: [PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER
Date: Sun, 11 Mar 2012 20:27:50 +0100 [thread overview]
Message-ID: <CACBZZX47hAF_ayaa_QBrGcOkZ9UpR0Uxm-4Hf=FB685OKKvYFw@mail.gmail.com> (raw)
In-Reply-To: <7vfwdg16i8.fsf@alter.siamese.dyndns.org>
On Sat, Mar 10, 2012 at 22:38, Junio C Hamano <gitster@pobox.com> wrote:
>> echo ' $(RM) blib/lib/Git.pm; cp Git.pm blib/lib/' >> $@
>> + echo ' $(RM) blib/lib/Git/I18N.pm; cp Git/I18N.pm blib/lib/Git/' >> $@
>> echo ' $(RM) blib/lib/Error.pm' >> $@
>> '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \
>> echo ' cp private-Error.pm blib/lib/Error.pm' >> $@
>> echo install: >> $@
>> echo ' mkdir -p "$$(DESTDIR)$(instdir_SQ)"' >> $@
>> + echo ' mkdir -p "$$(DESTDIR)$(instdir_SQ)/Git"' >> $@
>> echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Git.pm"; cp Git.pm "$$(DESTDIR)$(instdir_SQ)"' >> $@
>> + echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Git/I18N.pm"; cp Git/I18N.pm "$$(DESTDIR)$(instdir_SQ)/Git"' >> $@
>> echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@
>> '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \
>> echo ' cp private-Error.pm "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@
>> echo instlibdir: >> $@
>> echo ' echo $(instdir_SQ)' >> $@
>> + echo ' echo $(instdir_SQ)/Git' >> $@
>
> This break "make NO_PERL_MAKEMAKER=Nah git-add--interactive", or
> anything that is a perl script, it appears.
>
> The resulting perl/perl.mak ends with
>
> instlibdir:
> echo foo
> echo foo/Git
>
> but the top-level Makefile wants to see output from
>
> make instlibdir
Fail, I just tested installing it to /tmp. Sorry about that.
next prev parent reply other threads:[~2012-03-11 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 13:11 I18N.pm is incompatible with perl < 5.8.3 Tom G. Christensen
2012-02-02 16:48 ` Ævar Arnfjörð Bjarmason
2012-02-02 21:23 ` Tom G. Christensen
2012-03-07 12:56 ` Tom G. Christensen
2012-03-07 20:53 ` Ævar Arnfjörð Bjarmason
2012-03-10 12:29 ` [PATCH 0/2] Minor fixes for Perl + Git::I18N Ævar Arnfjörð Bjarmason
2012-03-10 12:29 ` [PATCH 1/2] Git::I18N: compatibility with perl <5.8.3 Ævar Arnfjörð Bjarmason
2012-03-10 12:29 ` [PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER Ævar Arnfjörð Bjarmason
2012-03-10 21:38 ` Junio C Hamano
2012-03-11 19:27 ` Ævar Arnfjörð Bjarmason [this message]
2012-03-16 16:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACBZZX47hAF_ayaa_QBrGcOkZ9UpR0Uxm-4Hf=FB685OKKvYFw@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tgc@statsbiblioteket.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).