* Add git config variable for signoff
@ 2022-12-16 19:50 Prajwal S N
2022-12-16 23:03 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Prajwal S N @ 2022-12-16 19:50 UTC (permalink / raw)
To: git
Hi all,
I noticed that git provides the config variable `gpgsign` to enable
GPG signing of commits by default (akin to the `-S` flag). But there
isn't a variable yet for signing off commits by default (akin to the
`-s` flag). I feel this would be a convenient feature to have, since a
large number of projects today require every commit to be signed off
for DCO[1]. I am willing to take this up, and would like to know if a
patch would be welcomed.
Thank you!
Best regards,
Prajwal S N
[1]: https://developercertificate.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Add git config variable for signoff
2022-12-16 19:50 Add git config variable for signoff Prajwal S N
@ 2022-12-16 23:03 ` Junio C Hamano
2022-12-19 17:26 ` Prajwal S N
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2022-12-16 23:03 UTC (permalink / raw)
To: Prajwal S N; +Cc: git
Prajwal S N <prajwalnadig21@gmail.com> writes:
> I noticed that git provides the config variable `gpgsign` to enable
> GPG signing of commits by default (akin to the `-S` flag). But there
> isn't a variable yet for signing off commits by default (akin to the
> `-s` flag). I feel this would be a convenient feature to have, since a
> large number of projects today require every commit to be signed off
> for DCO[1]. I am willing to take this up, and would like to know if a
> patch would be welcomed.
> Thank you!
>
> Best regards,
> Prajwal S N
>
> [1]: https://developercertificate.org/
I think the latest round was the thread leading to this message:
https://lore.kernel.org/git/xmqqpnfw8gyn.fsf@gitster-ct.c.googlers.com/
There was an earlier round:
https://lore.kernel.org/git/20161229084701.GA3643@starla/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Add git config variable for signoff
2022-12-16 23:03 ` Junio C Hamano
@ 2022-12-19 17:26 ` Prajwal S N
0 siblings, 0 replies; 3+ messages in thread
From: Prajwal S N @ 2022-12-19 17:26 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
> I think the latest round was the thread leading to this message:
>
> https://lore.kernel.org/git/xmqqpnfw8gyn.fsf@gitster-ct.c.googlers.com/
>
> There was an earlier round:
>
> https://lore.kernel.org/git/20161229084701.GA3643@starla/
I went through these threads as well as the other related ones, and I
understand some of the arguments. It definitely makes sense to have
this specifically as opt-in, since it is important for developers to
be aware that they are adding a DCO to their commits. This is exactly
what my patch suggestion proposes - let us not touch the defaults for
signing off, but simply provide a `commit.signoff` config flag
identical to the existing `format.signoff` flag that works with `git
format-patch`. This would mean that only the developers who regularly
signoff every commit can add this to their config, taking full
responsibility for choosing to do so :)
Cheers,
Prajwal S N
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-19 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-16 19:50 Add git config variable for signoff Prajwal S N
2022-12-16 23:03 ` Junio C Hamano
2022-12-19 17:26 ` Prajwal S N
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).