* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 18:03 Takahito Ogawa
2017-10-12 0:53 ` Junio C Hamano
0 siblings, 1 reply; 10+ messages in thread
From: Takahito Ogawa @ 2017-10-11 18:03 UTC (permalink / raw)
To: git; +Cc: Takahito Ogawa
"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but document says
"git stash save".
Correct it.
Signed-off-by: Takahito Ogawa <takahito.ogawa@datagrid.co.jp>
---
Documentation/git-stash.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
The modifications stashed away by this command can be listed with
`git stash list`, inspected with `git stash show`, and restored
(potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
A stash is by default listed as "WIP on 'branchname' ...", but
you can give a more descriptive message on the command line when
you create one.
--
2.13.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 18:06 Takahito Ogawa
0 siblings, 0 replies; 10+ messages in thread
From: Takahito Ogawa @ 2017-10-11 18:06 UTC (permalink / raw)
To: git; +Cc: Takahito Ogawa
"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but document says
"git stash save".
Correct it.
Signed-off-by: Takahito Ogawa <takahito.ogawa@datagrid.co.jp>
---
Documentation/git-stash.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
The modifications stashed away by this command can be listed with
`git stash list`, inspected with `git stash show`, and restored
(potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
A stash is by default listed as "WIP on 'branchname' ...", but
you can give a more descriptive message on the command line when
you create one.
--
2.13.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 18:37 Takahito Ogawa
2017-10-11 19:09 ` Thomas Gummerer
0 siblings, 1 reply; 10+ messages in thread
From: Takahito Ogawa @ 2017-10-11 18:37 UTC (permalink / raw)
To: git; +Cc: Takahito Ogawa
"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but documents says
"git stash save".
Correct it.
Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
---
Documentation/git-stash.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
The modifications stashed away by this command can be listed with
`git stash list`, inspected with `git stash show`, and restored
(potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
A stash is by default listed as "WIP on 'branchname' ...", but
you can give a more descriptive message on the command line when
you create one.
--
2.13.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
2017-10-11 18:37 Takahito Ogawa
@ 2017-10-11 19:09 ` Thomas Gummerer
2017-10-11 19:12 ` Thomas Gummerer
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Gummerer @ 2017-10-11 19:09 UTC (permalink / raw)
To: Takahito Ogawa; +Cc: git
On 10/12, Takahito Ogawa wrote:
> "git stash" behavior without any arguments was changed in
> 1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
> This is equivalent to "git stash push" but documents says
> "git stash save".
>
> Correct it.
Thanks for fixing this! I recently sent a patch that would advertise
git stash push more in general, which would also fix this occurrence [1],
but it didn't seem like it got much interest. However this is
obviously correct, and should definitely be fixed, while the other
places can still mention 'git stash save'.
For what it's worth this is
Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>
> Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
> ---
> Documentation/git-stash.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> index 00f95fee1..63642c145 100644
> --- a/Documentation/git-stash.txt
> +++ b/Documentation/git-stash.txt
> @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
> The modifications stashed away by this command can be listed with
> `git stash list`, inspected with `git stash show`, and restored
> (potentially on top of a different commit) with `git stash apply`.
> -Calling `git stash` without any arguments is equivalent to `git stash save`.
> +Calling `git stash` without any arguments is equivalent to `git stash push`.
> A stash is by default listed as "WIP on 'branchname' ...", but
> you can give a more descriptive message on the command line when
> you create one.
> --
> 2.13.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
2017-10-11 19:09 ` Thomas Gummerer
@ 2017-10-11 19:12 ` Thomas Gummerer
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Gummerer @ 2017-10-11 19:12 UTC (permalink / raw)
To: Takahito Ogawa; +Cc: git
On 10/11, Thomas Gummerer wrote:
> On 10/12, Takahito Ogawa wrote:
> > "git stash" behavior without any arguments was changed in
> > 1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
> > This is equivalent to "git stash push" but documents says
> > "git stash save".
> >
> > Correct it.
>
> Thanks for fixing this! I recently sent a patch that would advertise
> git stash push more in general, which would also fix this occurrence [1],
> but it didn't seem like it got much interest. However this is
> obviously correct, and should definitely be fixed, while the other
> places can still mention 'git stash save'.
>
> For what it's worth this is
>
> Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>
And I forgot to include the link, sorry. Here it is:
[1]: https://public-inbox.org/git/20171005200049.GF30301@hank/
>
> > Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
> > ---
> > Documentation/git-stash.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> > index 00f95fee1..63642c145 100644
> > --- a/Documentation/git-stash.txt
> > +++ b/Documentation/git-stash.txt
> > @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
> > The modifications stashed away by this command can be listed with
> > `git stash list`, inspected with `git stash show`, and restored
> > (potentially on top of a different commit) with `git stash apply`.
> > -Calling `git stash` without any arguments is equivalent to `git stash save`.
> > +Calling `git stash` without any arguments is equivalent to `git stash push`.
> > A stash is by default listed as "WIP on 'branchname' ...", but
> > you can give a more descriptive message on the command line when
> > you create one.
> > --
> > 2.13.1
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments
@ 2017-10-11 20:01 Takahito Ogawa
0 siblings, 0 replies; 10+ messages in thread
From: Takahito Ogawa @ 2017-10-11 20:01 UTC (permalink / raw)
To: gitster; +Cc: git, Takahito Ogawa
"git stash" behavior without any arguments was changed in
1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
This is equivalent to "git stash push" but documents says
"git stash save".
Correct it.
Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
---
Documentation/git-stash.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 00f95fee1..63642c145 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
The modifications stashed away by this command can be listed with
`git stash list`, inspected with `git stash show`, and restored
(potentially on top of a different commit) with `git stash apply`.
-Calling `git stash` without any arguments is equivalent to `git stash save`.
+Calling `git stash` without any arguments is equivalent to `git stash push`.
A stash is by default listed as "WIP on 'branchname' ...", but
you can give a more descriptive message on the command line when
you create one.
--
2.13.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-10-12 9:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 18:03 [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments Takahito Ogawa
2017-10-12 0:53 ` Junio C Hamano
[not found] ` <CAC2Jkr+ZDUxd9JcKvVwZqCHVW+Bpp2CbdyehwgKV_Ru-Uqxo8A@mail.gmail.com>
2017-10-12 3:52 ` 小川恭史
2017-10-12 3:54 ` 小川恭史
2017-10-12 9:56 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2017-10-11 18:06 Takahito Ogawa
2017-10-11 18:37 Takahito Ogawa
2017-10-11 19:09 ` Thomas Gummerer
2017-10-11 19:12 ` Thomas Gummerer
2017-10-11 20:01 Takahito Ogawa
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).