From: "Ville Skyttä" <ville.skytta@iki.fi>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/2] git-prompt.sh: Don't error on null ${ZSH,BASH}_VERSION, $short_sha
Date: Mon, 6 Jun 2016 19:33:12 +0300 [thread overview]
Message-ID: <CABr9L5A1i9Qiood7RnBiSOKAGOPLd+-Nh2b0B73RuFwVJygbKQ@mail.gmail.com> (raw)
On Mon, Jun 6, 2016 at 7:29 PM, Ville Skyttä <ville.skytta@iki.fi> wrote:
> When the shell is in "nounset" or "set -u" mode, referencing unset or
> null variables results in an error. Protect $ZSH_VERSION and
> $BASH_VERSION against that, and initialize $short_sha before use.
No part 2/2 will be coming, 1/2 is all there is to this change, sorry
about the confusion.
next reply other threads:[~2016-06-06 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 16:33 Ville Skyttä [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-06 16:29 [PATCH 1/2] git-prompt.sh: Don't error on null ${ZSH,BASH}_VERSION, $short_sha Ville Skyttä
2016-06-06 20:08 ` Junio C Hamano
2016-06-07 5:22 ` Ville Skyttä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABr9L5A1i9Qiood7RnBiSOKAGOPLd+-Nh2b0B73RuFwVJygbKQ@mail.gmail.com \
--to=ville.skytta@iki.fi \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).