git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Evan Grim <evangrim@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git commit-tree does not honor commit.gpgSign config
Date: Mon, 28 Sep 2020 13:42:43 -0600	[thread overview]
Message-ID: <CABX4Un3euDWeGr_2DegS3xyoD8VJ23rb9+bj3hBkWS6KZH9FhA@mail.gmail.com> (raw)
In-Reply-To: <xmqqd025n3ik.fsf@gitster.c.googlers.com>

Thank you for that context.  I came across this when I used
`git-subtree` and was surprised the commits it created weren't signed.
Would it be appropriate to look into patching `git-subtree` to honor
the configuration option?

On Mon, Sep 28, 2020 at 12:46 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Evan Grim <evangrim@gmail.com> writes:
>
> > Is it a bug that `git-commit-tree` doesn't honor the `commit.gpgSign`
> > configuration option?
>
> It would be a bug if it did, as a low level plumbing tool to build
> scripts around, it would not want its behaviour to be affected by
> end-user configuration (rather, scripts that are written using these
> plumbing command do want to handle end-user customization their own
> ways).

  reply	other threads:[~2020-09-28 19:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 16:21 git commit-tree does not honor commit.gpgSign config Evan Grim
2020-09-28 18:46 ` Junio C Hamano
2020-09-28 19:42   ` Evan Grim [this message]
2020-09-28 22:37     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABX4Un3euDWeGr_2DegS3xyoD8VJ23rb9+bj3hBkWS6KZH9FhA@mail.gmail.com \
    --to=evangrim@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).