From: Mateusz Loskot <mateusz@loskot.net>
To: git@vger.kernel.org
Subject: Re: "Submodule registered for path" output with config aliases mixed in
Date: Thu, 21 Feb 2019 11:53:12 +0100 [thread overview]
Message-ID: <CABUeae81zRSZrAce86R7OQgGFoc3R1Lk2X8Ujg4ZPUAGVVSknw@mail.gmail.com> (raw)
In-Reply-To: <20190221041756.GA28389@sigill.intra.peff.net>
On Thu, 21 Feb 2019 at 05:17, Jeff King <peff@peff.net> wrote:
> On Thu, Feb 21, 2019 at 10:47:45AM +0700, Duy Nguyen wrote:
>
> > > > I managed to identify where that garbage injections come from:
> > > > from git aliases I've got configured [1]
> > > >
> > > > Could anyone explain what is happening here?
> > > > Is there anything wrong with my ~/.gitconfig [1] ?
> > >
> > > I see the right behavior on my system (Debian amd64/sid) with
> > > 2.21.0.rc0.258.g878e2cd30e and with master. I've built with ASan and
> > > don't see any memory warnings on my system.
> >
> > I ran valgrind yesterday (gentoo amd64) and didn't find the problem
> > either even though it clearly looked like some dangling pointers. I
> > also audited this code and couldn't find anything obviously wrong. My
> > only suspicion is maybe some strange getenv() behavior on Windows
> > (_if_ the super prefix is used, but I can't see how...) and that's
> > just a dead end for me.
>
> Certainly we fixed a bunch of getenv() problems in the upcoming 2.21
> release, including 8aac69038f (get_super_prefix(): copy getenv() result,
> 2019-01-11).
>
> Mateusz, can you try with the one of the v2.21.0 release candidates (or
> the current tip of "master")?
Jeff, I have just tried git version 2.21.0.rc2.windows.1 and
I no longer see the problem.
It seems like a bug in earlier version indeed, that has been fixed now.
Brian, yes, the .gitmodules was perfectly correct.
Brian, Duy, Jeff, thank you all for responding; the problem has
been solved for me now.
Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net
next prev parent reply other threads:[~2019-02-21 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 16:51 "Submodule registered for path" output with config aliases mixed in Mateusz Loskot
2019-02-20 16:30 ` Mateusz Loskot
2019-02-21 2:18 ` brian m. carlson
2019-02-21 3:47 ` Duy Nguyen
2019-02-21 4:17 ` Jeff King
2019-02-21 10:53 ` Mateusz Loskot [this message]
2019-02-21 13:07 ` Jeff King
2019-02-21 20:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABUeae81zRSZrAce86R7OQgGFoc3R1Lk2X8Ujg4ZPUAGVVSknw@mail.gmail.com \
--to=mateusz@loskot.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).