From: Phil Hord <phil.hord@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
Git <git@vger.kernel.org>, Denton Liu <liu.denton@gmail.com>
Subject: Re: [PATCH/RFC 0/2] rebase: add switches to control todo-list setup
Date: Mon, 22 Apr 2019 19:20:36 -0700 [thread overview]
Message-ID: <CABURp0rLg=E6MT9Ld5EXpk127PURYMPdP9Mgo7duyerO-yCPOg@mail.gmail.com> (raw)
In-Reply-To: <xmqq4l6p7bz7.fsf@gitster-ct.c.googlers.com>
On Mon, Apr 22, 2019 at 6:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Phillip Wood <phillip.wood123@gmail.com> writes:
>
> > Doing "git rebase -i master" and then editing the todo list has the
> > side effect of rebasing the branch. Often I find I want to amend or
> > reword a commit without rebasing (for instance when preparing a
> > re-roll).
>
> I am not sure what you mean by "not rebasing". Are you talking
> about --keep-base that uses the same --onto as the previous?
>
> I think that is often desired, but I do not think it has much to do
> with the topic of the proposal these two patches raises.
>
> And that (i.e. "this has nothing to do with the choice of 'onto'")
> was why I used the casual "rebase -i master" in my illustrations.
I know exactly what he means, because it usually is exactly what I
want to do here. In fact, I almost always want `rebase --interactive`
to do this "in-place" editing of the history. Sure, I may want to
`rebase @{upstream}` someday, but I seldom use --interactive for that.
Rebase invites conflicts. It's nice to invite as few as possible at once.
P
next prev parent reply other threads:[~2019-04-23 2:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 0:07 [PATCH/RFC 0/2] rebase: add switches to control todo-list setup Phil Hord
2019-04-22 0:07 ` [PATCH/RFC 1/2] rebase: add switches for drop, edit and reword Phil Hord
2019-04-22 0:07 ` [PATCH/RFC 2/2] rebase: add --break switch Phil Hord
2019-04-22 1:13 ` [PATCH/RFC 0/2] rebase: add switches to control todo-list setup Junio C Hamano
2019-04-22 14:44 ` Phillip Wood
2019-04-22 19:16 ` Phil Hord
2019-04-22 19:20 ` Phil Hord
2019-04-22 19:49 ` Denton Liu
2019-04-23 1:21 ` Junio C Hamano
2019-04-23 2:20 ` Phil Hord [this message]
2019-04-22 17:50 ` Phil Hord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABURp0rLg=E6MT9Ld5EXpk127PURYMPdP9Mgo7duyerO-yCPOg@mail.gmail.com' \
--to=phil.hord@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).