* doc: prefer 'stash push' over 'stash save'
@ 2017-11-21 23:05 Phil Hord
2017-11-21 23:21 ` Jonathan Nieder
0 siblings, 1 reply; 4+ messages in thread
From: Phil Hord @ 2017-11-21 23:05 UTC (permalink / raw
To: Git, Thomas Gummerer
Although `git stash save` was deprecated recently, some parts of the
documentation still refer to it instead of `push`.
Signed-off-by: Phil Hord <phil.hord@gmail.com>
---
Documentation/git-stash.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 8be661007..056dfb866 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -175,14 +175,14 @@ create::
return its object name, without storing it anywhere in the ref
namespace.
This is intended to be useful for scripts. It is probably not
- the command you want to use; see "save" above.
+ the command you want to use; see "push" above.
store::
Store a given stash created via 'git stash create' (which is a
dangling merge commit) in the stash ref, updating the stash
reflog. This is intended to be useful for scripts. It is
- probably not the command you want to use; see "save" above.
+ probably not the command you want to use; see "push" above.
DISCUSSION
----------
--
2.15.0.471.g17a719cfe.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: doc: prefer 'stash push' over 'stash save'
2017-11-21 23:05 doc: prefer 'stash push' over 'stash save' Phil Hord
@ 2017-11-21 23:21 ` Jonathan Nieder
2017-11-22 4:39 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Nieder @ 2017-11-21 23:21 UTC (permalink / raw
To: Phil Hord; +Cc: Git, Thomas Gummerer
Phil Hord wrote:
> Although `git stash save` was deprecated recently, some parts of the
> documentation still refer to it instead of `push`.
>
> Signed-off-by: Phil Hord <phil.hord@gmail.com>
> ---
> Documentation/git-stash.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: doc: prefer 'stash push' over 'stash save'
2017-11-21 23:21 ` Jonathan Nieder
@ 2017-11-22 4:39 ` Junio C Hamano
2017-11-22 16:41 ` Phil Hord
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2017-11-22 4:39 UTC (permalink / raw
To: Jonathan Nieder; +Cc: Phil Hord, Git, Thomas Gummerer
Jonathan Nieder <jrnieder@gmail.com> writes:
> Phil Hord wrote:
>
>> Although `git stash save` was deprecated recently, some parts of the
>> documentation still refer to it instead of `push`.
>>
>> Signed-off-by: Phil Hord <phil.hord@gmail.com>
>> ---
>> Documentation/git-stash.txt | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> Thanks.
Heh, this does not even apply to 8be661007 that it claims to apply
on top of, which is contained in fd2ebf14 ("stash: mark "git stash
save" deprecated in the man page", 2017-10-22).
I've wiggled it in, so there is no need to resend, but next time
please be careful when sending the patch and also when sending a
reviewed-by.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: doc: prefer 'stash push' over 'stash save'
2017-11-22 4:39 ` Junio C Hamano
@ 2017-11-22 16:41 ` Phil Hord
0 siblings, 0 replies; 4+ messages in thread
From: Phil Hord @ 2017-11-22 16:41 UTC (permalink / raw
To: Junio C Hamano; +Cc: Jonathan Nieder, Git, Thomas Gummerer
You probably already noticed this was my fault for filtering the patch
through Gmail's GUI. I did also push a replacement which hopefully
does apply.
On Tue, Nov 21, 2017 at 8:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Phil Hord wrote:
>>
>>> Although `git stash save` was deprecated recently, some parts of the
>>> documentation still refer to it instead of `push`.
>>>
>>> Signed-off-by: Phil Hord <phil.hord@gmail.com>
>>> ---
>>> Documentation/git-stash.txt | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>> Thanks.
>
> Heh, this does not even apply to 8be661007 that it claims to apply
> on top of, which is contained in fd2ebf14 ("stash: mark "git stash
> save" deprecated in the man page", 2017-10-22).
>
> I've wiggled it in, so there is no need to resend, but next time
> please be careful when sending the patch and also when sending a
> reviewed-by.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-22 16:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-21 23:05 doc: prefer 'stash push' over 'stash save' Phil Hord
2017-11-21 23:21 ` Jonathan Nieder
2017-11-22 4:39 ` Junio C Hamano
2017-11-22 16:41 ` Phil Hord
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).