From: Elijah Newren <firstname.lastname@example.org> To: Luke Shumaker <email@example.com> Cc: "Junio C Hamano" <firstname.lastname@example.org>, "Git Mailing List" <email@example.com>, "Jeff King" <firstname.lastname@example.org>, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, "Nguyễn Thái Ngọc Duy" <email@example.com>, "Taylor Blau" <firstname.lastname@example.org>, "brian m . carlson" <email@example.com>, "Eric Sunshine" <firstname.lastname@example.org>, "Luke Shumaker" <email@example.com> Subject: Re: [PATCH v3 3/3] fast-export, fast-import: implement signed-commits Date: Thu, 29 Apr 2021 15:38:57 -0700 [thread overview] Message-ID: <CABPp-BHhfT3b=UyWOXACrBb6nw86n74thNAx7DUDF0YNOcA-yA@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Thu, Apr 29, 2021 at 1:06 PM Luke Shumaker <email@example.com> wrote: > > On Tue, 27 Apr 2021 22:02:47 -0600, > Junio C Hamano wrote: > > > > Luke Shumaker <firstname.lastname@example.org> writes: > > > > > +--signed-commits=(verbatim|warn-verbatim|warn-strip|strip|abort):: > > > + Specify how to handle signed commits. Behaves exactly as > > > + --signed-tags (but for commits), except that the default is > > > + 'warn-strip' rather than 'abort'. > > > > Why deliberate inconsistency? I am not sure "historically we did a > > wrong thing" is a good reason (if we view that silently stripping > > was a disservice to the users, aborting would be a bugfix). > > I *almost* agree. I agree in principle, but disagree in practice > because I know that it would break a bunch of existing tooling, > including git-filter-repo. I understand that fast-export's behavior in the past matched what --signed-commits=warn-strip would now do, and thus you wanted to select it for backward compatibility. But throwing an error and making the user choose when they are potentially losing data seems like a safer choice to me. I do get that we might have to use warn-strip as the default anyway just because some existing tools might rely on it, but do you have any examples outside of git-filter-repo? Given the filter-repo bug reports I've gotten with users being surprised at commit signatures being stripped (despite the fact that this is documented -- users don't always read the documentation), I'd argue that changing to --signed-commits=abort as the default is probably a good bugfix for both fast-export and for filter-repo. Clearly, it'd probably make sense for filter-repo to also add an option for the user to select to: (0) abort if commit signatures are found, (1) strip commit signatures, (2) retain commit signatures even if they are invalid, or (3) only retain commit signatures if they are valid. In the past, we could only reasonably do (1). Your series makes (0) and (2) possible. More work in fast-import would be needed to make (3) a possibility, so I wouldn't be able to add it to filter-repo yet, but I could add the other options.
next prev parent reply other threads:[~2021-04-29 22:39 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 0:27 [PATCH v2 0/3] " Luke Shumaker 2021-04-22 0:27 ` [PATCH v2 1/3] git-fast-import.txt: add missing LF in the BNF Luke Shumaker 2021-04-22 0:27 ` [PATCH v2 2/3] fast-export: rename --signed-tags='warn' to 'warn-verbatim' Luke Shumaker 2021-04-22 3:59 ` Eric Sunshine 2021-04-22 4:43 ` Luke Shumaker 2021-04-22 4:50 ` Luke Shumaker 2021-04-22 0:27 ` [PATCH v2 3/3] fast-export, fast-import: implement signed-commits Luke Shumaker 2021-04-23 16:41 ` [PATCH v3 0/3] " Luke Shumaker 2021-04-23 16:41 ` [PATCH v3 1/3] git-fast-import.txt: add missing LF in the BNF Luke Shumaker 2021-04-23 16:41 ` [PATCH v3 2/3] fast-export: rename --signed-tags='warn' to 'warn-verbatim' Luke Shumaker 2021-04-28 3:29 ` Junio C Hamano 2021-04-29 19:02 ` Luke Shumaker 2021-04-30 0:03 ` Junio C Hamano 2021-04-23 16:41 ` [PATCH v3 3/3] fast-export, fast-import: implement signed-commits Luke Shumaker 2021-04-28 4:02 ` Junio C Hamano 2021-04-29 20:06 ` Luke Shumaker 2021-04-29 22:38 ` Elijah Newren [this message] 2021-04-29 23:42 ` Junio C Hamano 2021-04-30 2:23 ` Elijah Newren 2021-04-30 3:20 ` Junio C Hamano 2021-04-30 17:07 ` Luke Shumaker 2021-04-30 19:34 ` Luke Shumaker 2021-04-30 19:59 ` Elijah Newren 2021-04-30 22:21 ` Luke Shumaker 2021-04-30 23:25 ` [PATCH v4 0/5] fast-export, fast-import: add support for signed-commits Luke Shumaker 2021-04-30 23:25 ` [PATCH v4 1/5] git-fast-import.txt: add missing LF in the BNF Luke Shumaker 2021-04-30 23:25 ` [PATCH v4 2/5] fast-export: rename --signed-tags='warn' to 'warn-verbatim' Luke Shumaker 2021-04-30 23:25 ` [PATCH v4 3/5] git-fast-export.txt: clarify why 'verbatim' may not be a good idea Luke Shumaker 2021-04-30 23:25 ` [PATCH v4 4/5] fast-export: do not modify memory from get_commit_buffer Luke Shumaker 2021-05-03 4:41 ` Junio C Hamano 2021-04-30 23:25 ` [PATCH v4 5/5] fast-export, fast-import: add support for signed-commits Luke Shumaker 2021-05-03 5:09 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CABPp-BHhfT3b=UyWOXACrBb6nw86n74thNAx7DUDF0YNOcA-yA@mail.gmail.com' \ --email@example.com \ --cc=Johannes.Schindelin@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v3 3/3] fast-export, fast-import: implement signed-commits' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).