From: Elijah Newren <newren@gmail.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] Remove unnecessary inclusions of parse-options.h from headers
Date: Mon, 20 Mar 2023 09:41:03 -0700 [thread overview]
Message-ID: <CABPp-BHVsxVQJrar3qc1xGCSwFXKtBmma1V4xo__8YMOi0Xc2w@mail.gmail.com> (raw)
In-Reply-To: <20230319162712.654137-1-szeder.dev@gmail.com>
On Sun, Mar 19, 2023 at 10:13 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> Some source files use parse_options(), but don't include
> parse-options.h, while some headers do include parse-options.h, though
> don't really need it. These patches fix these issues.
Nice!
Reviewed-by: Elijah Newren <newren@gmail.com>
> This series has a small and simple conflict with the 'ds/ahead-behind'
> topic, and it will have small conflicts with Elijah's header cleanup
> series as well:
>
> https://public-inbox.org/git/pull.1493.git.1679207282.gitgitgadget@gmail.com/T/#t
Perhaps it makes sense to rebase your series on that one? (And/or add
the headers earlier in the list instead of at the end to reduce the
odds of patch collisions? I really wish we had our #include's in
alphabetical order instead of always appending to the end, because it
both reduces the odds of conflicts and is so much easier for humans to
check.)
prev parent reply other threads:[~2023-03-20 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 16:27 [PATCH 0/2] Remove unnecessary inclusions of parse-options.h from headers SZEDER Gábor
2023-03-19 16:27 ` [PATCH 1/2] treewide: include parse-options.h in source files SZEDER Gábor
2023-03-19 16:27 ` [PATCH 2/2] treewide: remove unnecessary inclusions of parse-options.h from headers SZEDER Gábor
2023-03-20 16:41 ` Elijah Newren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPp-BHVsxVQJrar3qc1xGCSwFXKtBmma1V4xo__8YMOi0Xc2w@mail.gmail.com \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).