From: Elijah Newren <newren@gmail.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: JunkYardMail1 <JunkYardMail1@frontier.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Sparse Checkout Trouble (2.5.0)
Date: Mon, 27 Jan 2020 21:21:41 -0800 [thread overview]
Message-ID: <CABPp-BHRAA71LmfYb61N+qAgwhtii7TSEVJksiAGnnO-4bk2dQ@mail.gmail.com> (raw)
In-Reply-To: <de300697-baba-62a6-ea4c-c5bd472954c2@gmail.com>
On Sun, Jan 26, 2020 at 6:09 AM Derrick Stolee <stolee@gmail.com> wrote:
>
> On 1/25/2020 3:59 PM, Elijah Newren wrote:
> > On Fri, Jan 24, 2020 at 7:41 AM Derrick Stolee <stolee@gmail.com> wrote:
> >> I'm CC'ing Elijah because he also made changes to dir.c, and
> >> perhaps he has some idea of what's going on.
> >
> > If you think it might be related to the dir.c changes, I can take a
> > look. I don't have any immediate ideas off the top of my head.
>
> The only thing I can think of is that these paths are already
> marked as sparse, but something is requiring us to test if the
> path can be created with the filesystem. I'll try to debug
> more into exactly where that is. It's telling that this happens
> both in cone mode and without.
Yeah, I'll take a look. The exponentially slow 'status --ignored'
report is forcing me to look at dir.c again anyway, though it's also
delaying me from getting a chance to look at this particular report.
> > However, since I'm really suffering with "git read-tree -mu HEAD"
> > being the mechanism for updating sparsity (for reasons independent of
> > the issue being discussed here), I've been tempted to dig into that
> > anyway to write a replacement without the nasty side-effects. I'll
> > take a look early next week and see if I can spot anything.
>
> If by "nasty side-effects" you mean "overwrites staged changes, even
> if in the sparse set before and after" then I would welcome such a
> change. Otherwise, it will fall to me, and this is far outside of
> my expertise. Of course, it is something I should learn, but I can
> learn that during code review, too. ;)
Yep, that's exactly what I mean. It'd be nice if Duy were still
around to bug, but I've touched unpack-trees a few times so I might be
able to find my way around. I'll try to take a stab at it.
> Thanks,
> -Stolee
next prev parent reply other threads:[~2020-01-28 5:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 0:42 Sparse Checkout Trouble (2.5.0) JunkYardMail1
2020-01-22 1:19 ` Derrick Stolee
2020-01-22 2:06 ` JunkYardMail1
2020-01-24 15:40 ` Derrick Stolee
2020-01-25 20:59 ` Elijah Newren
2020-01-26 14:09 ` Derrick Stolee
2020-01-28 5:21 ` Elijah Newren [this message]
2020-01-28 20:47 ` Derrick Stolee
2020-01-29 15:30 ` Johannes Schindelin
2020-01-29 15:40 ` Derrick Stolee
2020-01-29 16:31 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPp-BHRAA71LmfYb61N+qAgwhtii7TSEVJksiAGnnO-4bk2dQ@mail.gmail.com \
--to=newren@gmail.com \
--cc=JunkYardMail1@frontier.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).