From: Elijah Newren <newren@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 09/23] config.c: mark more strings for translation
Date: Sat, 30 Jun 2018 22:38:11 -0700 [thread overview]
Message-ID: <CABPp-BHQSTxe4=adMSo9Arg0QT7-U_SjsU-AgO42cHiMgUxPog@mail.gmail.com> (raw)
In-Reply-To: <20180630090818.28937-10-pclouds@gmail.com>
On Sat, Jun 30, 2018 at 2:08 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> @@ -1409,11 +1409,11 @@ static int git_default_push_config(const char *var, const char *value)
> push_default = PUSH_DEFAULT_UPSTREAM;
> else if (!strcmp(value, "current"))
> push_default = PUSH_DEFAULT_CURRENT;
> - else {
> - error("malformed value for %s: %s", var, value);
> - return error("Must be one of nothing, matching, simple, "
> - "upstream or current.");
> - }
> + else
> + return error(_("malformed value for %s: %s\n"
> + "Must be one of nothing, matching, simple, "
> + "upstream or current."),
> + var, value);
Patch 1?
No other issues noticed.
next prev parent reply other threads:[~2018-07-01 5:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 9:07 [PATCH 00/23] Mark strings for translation Nguyễn Thái Ngọc Duy
2018-06-30 9:07 ` [PATCH 01/23] Update messages in preparation for i18n Nguyễn Thái Ngọc Duy
2018-06-30 9:07 ` [PATCH 02/23] archive-tar.c: mark more strings for translation Nguyễn Thái Ngọc Duy
2018-06-30 9:07 ` [PATCH 03/23] archive-zip.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:07 ` [PATCH 04/23] builtin/config.c: " Nguyễn Thái Ngọc Duy
2018-07-01 5:18 ` Elijah Newren
2018-06-30 9:08 ` [PATCH 05/23] builtin/grep.c: mark strings for translation and no full stops Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 06/23] builtin/pack-objects.c: mark more strings for translation Nguyễn Thái Ngọc Duy
2018-07-01 5:28 ` Elijah Newren
2018-06-30 9:08 ` [PATCH 07/23] builtin/replace.c: " Nguyễn Thái Ngọc Duy
2018-07-01 5:34 ` Elijah Newren
2018-06-30 9:08 ` [PATCH 08/23] commit-graph.c: " Nguyễn Thái Ngọc Duy
2018-07-02 20:32 ` Derrick Stolee
2018-06-30 9:08 ` [PATCH 09/23] config.c: " Nguyễn Thái Ngọc Duy
2018-07-01 5:38 ` Elijah Newren [this message]
2018-06-30 9:08 ` [PATCH 10/23] connect.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 11/23] convert.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 12/23] dir.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 13/23] environment.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 14/23] exec-cmd.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 15/23] object.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 16/23] pkt-line.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 17/23] refs.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 18/23] refspec.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 19/23] replace-object.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 20/23] sequencer.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 21/23] sha1-file.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 22/23] transport.c: " Nguyễn Thái Ngọc Duy
2018-06-30 9:08 ` [PATCH 23/23] transport-helper.c: " Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BHQSTxe4=adMSo9Arg0QT7-U_SjsU-AgO42cHiMgUxPog@mail.gmail.com' \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).