From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/4] progress: Fix progress meters when dealing with lots of work
Date: Mon, 13 Nov 2017 12:05:05 -0800 [thread overview]
Message-ID: <CABPp-BH1Cpc9UfYpmBBAHWSqadg=QuD=28qx1oV29ZdvF4NbJw@mail.gmail.com> (raw)
In-Reply-To: <xmqqtvxy92ey.fsf@gitster.mtv.corp.google.com>
Thanks for the reviews and suggestions!
On Sun, Nov 12, 2017 at 9:24 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Elijah Newren <newren@gmail.com> writes:
>
>> Subject: Re: [PATCH 3/4] progress: Fix progress meters when dealing with lots of work
>
> Style: s/Fix/fix/;
I also messed this up in a lot of my patches in my other patch series.
I've fixed them all up, but I'll wait to resubmit those other series
until I get some other reviews.
> The middle part of the log message may waste more mental bandwidth
> of readers than it is worth. It might have gave you satisfaction to
> be able to vent, but don't (the place to do so is after the three
> dash lines).
Cleaned it up, along with the other commit message you pointed out;
I'll resubmit shortly.
> I am not sure if we want all codepaths to do 64-bit math for
> progress meter, but let's see what others would think.
If others don't want to do 64-bit math for the progress meter, what
would they like to see done instead? I can see a few options:
1) Have two separate progress codepaths, one for 32-bith math and
one for 64-bit math.
2) Instead of counting pairs of source/dest files compared, just
count number of dest paths completed. (Thus, we wouldn't need a value
big enough to hold rename_dst_nr * rename_src_nr, just big enough to
hold rename_dst_nr).
3) just let the progress meter overflow and show nonsensical values
4) don't show the progress meter if overflow would happen
5) something else I'm not thinking of.
>> - fprintf(stderr, "%s: %3u%% (%u/%u)%s%s",
>> + fprintf(stderr, "%s: %3u%% (%lu/%lu)%s%s",
>
> Are these (and there are probably other instances in this patch) %lu
> correct?
Oops, no. I think %llu is right, though looking around the code it
appears folks use PRIuMAX and avoid %llu due to possible issues with
old windows compilers. Not sure if that's still relevant, but I'll
try to remain consistent with what I see elsewhere and include that
fix in my re-roll.
next prev parent reply other threads:[~2017-11-13 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 17:39 [PATCH 0/4] Fix issues with rename detection limits Elijah Newren
2017-11-10 17:39 ` [PATCH 1/4] sequencer: Warn when internal merge may be suboptimal due to renameLimit Elijah Newren
2017-11-13 5:16 ` Junio C Hamano
2017-11-10 17:39 ` [PATCH 2/4] Remove silent clamp of renameLimit Elijah Newren
2017-11-10 18:26 ` Stefan Beller
2017-11-10 18:36 ` Elijah Newren
2017-11-10 23:42 ` brian m. carlson
2017-11-11 16:39 ` Elijah Newren
2017-11-11 17:32 ` brian m. carlson
2017-11-10 17:39 ` [PATCH 3/4] progress: Fix progress meters when dealing with lots of work Elijah Newren
2017-11-13 5:24 ` Junio C Hamano
2017-11-13 20:05 ` Elijah Newren [this message]
2017-11-14 1:18 ` Junio C Hamano
2017-11-10 17:39 ` [PATCH 4/4] sequencer: Show rename progress during cherry picks Elijah Newren
2017-11-13 5:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BH1Cpc9UfYpmBBAHWSqadg=QuD=28qx1oV29ZdvF4NbJw@mail.gmail.com' \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).