From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C9A811F406 for ; Sat, 11 Nov 2023 04:05:14 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=VR1hc8yK; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8C393280D56 for ; Sat, 11 Nov 2023 04:05:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AEBF463DA; Sat, 11 Nov 2023 04:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VR1hc8yK" Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E655E63AE for ; Sat, 11 Nov 2023 04:05:04 +0000 (UTC) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D8922591 for ; Fri, 10 Nov 2023 20:05:03 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-507a98517f3so3493704e87.0 for ; Fri, 10 Nov 2023 20:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699675502; x=1700280302; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Owj3sI3q8dAZk3QfQqDs/JMz+VDlYLjH2oy9YzE5Prs=; b=VR1hc8yKzrl7x6f/IXoTJMqUVK6+Gq562IWQ/SyhfJoG7j6Lyhwgg3p9TeygB4+Uhz 2ksjLL++BJ2EiLM3uPNH+7+MxyTgoF4WvK4inLHFIo7DhvpceQ98mxTebCxUiFFENzyA oTtthnV1VTlCM7Pv65cMUtV7RJvK93ilG2Tnw5XWtODcFzfWBRf9cQckV6xBwzlqbHhk VYbwLbyKkgqFi2QGv7+TTQ+mCjeK2EIdhplR7Xx5dzc/Y+1lMhY7IiDvHdQb9BYJAr6y m2lp+t/VZ+qKqo6RvziHrcMEMOgIm1M3wT1IcNw6heNYK6WMuSBmfd+fwm5e9/dCr6XV Pjxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699675502; x=1700280302; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Owj3sI3q8dAZk3QfQqDs/JMz+VDlYLjH2oy9YzE5Prs=; b=u+53UYAYfxVv+MlUoxxqEPJOLsjG/PHpSCC0glHcNl/O4oAgMXCQkaFqO6uU0he06u raPMPOyr1qQDC1nHf64Nxj114IXX9599lZhdK4Q/lKPMh6QU3MmDlfnX02DyrDBNFS0q SUzj6xz11TXTxX8tX9agkxqS1E3U3R6RJwDmbjdSMOwsElBzkrwNBiBK+NWsoiBA9Vqp 9RCQ9/gDP+oiosE5j60uC3Z2pzhBqSeff+M3OtyrfkifGh4nYkdu/crIcVh2r+O+BMoa ljKEvicwikDr5gB5gtwDXvZlTAAkaSyRTKfDSGdYQfUzC/o/PrZrWJd0jvuVkG3HHdDu B8SA== X-Gm-Message-State: AOJu0YyIsMeHPepY90G517Ves8RBMdMrVV2kKQb62dFr4BqyLmP+KBbj 1sY6fUKSE8SzuKPGtVJmxa+fRaLGGV9yGYcnHXE= X-Google-Smtp-Source: AGHT+IFWARxh+TDye7Fx8TWuliNNJQjGs7z8cXXILcs2hph6DE269GtNvpKUZ5O+YqIAaZWLYtQIqzkyBXXhBb1uUfM= X-Received: by 2002:a19:9103:0:b0:507:9f4c:b72 with SMTP id t3-20020a199103000000b005079f4c0b72mr447411lfd.15.1699675501619; Fri, 10 Nov 2023 20:05:01 -0800 (PST) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 References: In-Reply-To: From: Elijah Newren Date: Fri, 10 Nov 2023 20:04:49 -0800 Message-ID: Subject: Re: [RFC PATCH 0/3] replay: implement support for writing new objects to a pack To: Taylor Blau Cc: git@vger.kernel.org, Jeff King , Patrick Steinhardt , Junio C Hamano , Johannes Schindelin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Unsubscribe-Post: List-Unsubscribe=One-Click On Tue, Nov 7, 2023 at 10:22=E2=80=AFAM Taylor Blau wrote= : > > (Based on a combination of Christian's cc/git-replay and my > tb/merge-tree-write-pack branches). > > This RFC demonstrates extending the new `--write-pack` option that > `merge-tree` recently learned to the `replay` builtin as well. > > The approach is as follows: > > - write a pack out after each step in the replay operation, so that > subsequent steps may see any new object(s) created during previous > steps > > - combine those packs into one before migrating them back into the > main object store > > This is accomplished with a combination of the bulk-checkin and > tmp-objdir APIs, with some minor modifications made to when we flush out > and finalize bulk-checkin transactions. Just thought I'd note that I finished reading all of this series as well as the five-commit series it's based on. Just wanted to note that any commits I didn't comment on from either series looked good to me.