Re: What's cooking in git.git (Jul 2021, #01; Tue, 6)

[Elijah Newren <newren@gmail.com>]

On Tue, Jul 6, 2021 at 6:20 PM Junio C Hamano <gitster@pobox.com> wrote:

> * ds/commit-and-checkout-with-sparse-index (2021-06-28) 5 commits
>  - checkout: stop expanding sparse indexes
>  - sparse-index: recompute cache-tree
>  - commit: integrate with sparse-index
>  - p2000: compress repo names
>  - p2000: add 'git checkout -' test and decrease depth
>  (this branch uses ds/status-with-sparse-index.)
>
>  "git checkout" and "git commit" learn to work without unnecessarily
>  expanding sparse indexes.
>
>  Comments?

This was submitted at the same time as the latest round of
ds/status-with-sparse-index.  Last week was a bit busy for me.  I'd
like to complete reviewing the latest round from the other series,
then I'll review this one.  So I'll have some comments soon-ish (by
end of week).

> * ds/status-with-sparse-index (2021-06-28) 16 commits
>  - fsmonitor: integrate with sparse index
>  - wt-status: expand added sparse directory entries
>  - status: use sparse-index throughout
>  - status: skip sparse-checkout percentage with sparse-index
>  - diff-lib: handle index diffs with sparse dirs
>  - dir.c: accept a directory as part of cone-mode patterns
>  - unpack-trees: handle dir/file conflict of sparse entries
>  - unpack-trees: unpack sparse directory entries
>  - unpack-trees: rename unpack_nondirectories()
>  - unpack-trees: compare sparse directories correctly
>  - unpack-trees: preserve cache_bottom
>  - t1092: add tests for status/add and sparse files
>  - t1092: expand repository data shape
>  - t1092: replace incorrect 'echo' with 'cat'
>  - sparse-index: include EXTENDED flag when expanding
>  - sparse-index: skip indexes with unmerged entries
>  (this branch is used by ds/commit-and-checkout-with-sparse-index.)
>
>  "git status" codepath learned to work with sparsely populated index
>  without hydrating it fully.
>
>  Will merge to 'next'?

Sorry for the delay.  I reviewed about half of the latest round last
week, and it appears all my feedback from earlier rounds was addressed
from what I've seen so far.  I suspect this series is now good to go
and I'd like to stick my Reviewed-by on it before it goes to next, but
I need to complete my review first.   I should be able to complete it
by end of week.

> * jt/partial-clone-submodule-1 (2021-06-28) 5 commits
>  - promisor-remote: teach lazy-fetch in any repo
>  - run-command: refactor subprocess env preparation
>  - submodule: refrain from filtering GIT_CONFIG_COUNT
>  - promisor-remote: support per-repository config
>  - repository: move global r_f_p_c to repo struct
>
>  Prepare the internals for lazily fetching objects in submodules
>  from their promisor remotes.
>
>  Waiting for reviews.

I reviewed here:
https://lore.kernel.org/git/CABPp-BFQhBN-MEGgkyK7gcnuQp01Xfj17TrTcH04yuadXuRu3Q@mail.gmail.com/.
Sure, I left my Reviewed-by off of patch 3, but that's because I roped
Peff in and he explained to me why that patch (and more the
pre-existing code) worked and was good.  So he's the one that reviewed
that patch.  :-)

Besides Peff and I, three other folks provided feedback on previous
rounds -- Taylor, Emily, and you.

So, I think it's gotten reviews.  Another reviewer could come along
and request additional changes, but short of someone showing up soon,
I'd say this one is good to merge to 'next' (well, maybe after it's
re-rolled to include my Reviewed-by)