git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: Raise your hand to Ack jk/code-of-conduct if your Ack fell thru cracks
Date: Wed, 9 Oct 2019 11:29:19 -0700	[thread overview]
Message-ID: <CABPp-BGjaOofi_gWEatKnnkpY04OOyMDZucXqQ-FPYw8yeCacw@mail.gmail.com> (raw)
In-Reply-To: <xmqqd0f6n5a4.fsf_-_@gitster-ct.c.googlers.com>

On Tue, Oct 8, 2019 at 5:20 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > In other words, the commit message can be augmented by this:
> >
> > Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > Acked-by: Derrick Stolee <stolee@gmail.com>
> > Acked-by: Garima Singh <garimasigit@gmail.com>
> > Acked-by: Jonathan Tan <jonathantanmy@google.com>
> > Acked-by: Thomas Gummerer <t.gummerer@gmail.com>
> > Acked-by: brian m. carlson <sandals@crustytoothpaste.net>
> > Acked-by: Elijah Newren <newren@gmail.com>
> >
> > Junio, would you mind picking it up, please?
>
> I trust you enough that I won't go back to the cited messages to
> double check that these acks are real, but I'd still wait for a few
> days for people who expressed their Acks but your scan missed, or
> those who wanted to give their Acks but forgot to do so, to raise
> their hands on this thread.
>
> Thanks for starting the concluding move on this topic.

Agreed, thanks.  There is one super minor issue, that I probably
shouldn't even bring up but... Looking at jk/coc, it ends with:

Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Christian Couder <chriscool@tuxfamily.org>
Acked-by: Emily Shaffer <emilyshaffer@google.com>
Acked-by: Garima Singh <garimasigit@gmail.com>
Acked-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked-by: Jonathan Tan <jonathantanmy@google.com>
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Taylor Blau <me@ttaylorr.com>
Acked-by: Elijah Newren <newren@gmail.com>
Acked-by: brian m. carlson <sandals@crustytoothpaste.net>
Acked-by: Derrick Stolee <stolee@gmail.com>
Acked-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Those Acked-by's are nearly in alphabetical order (at least at first
glance) until Brian, Derrick, and me.  I know it's a trivial thing,
but for the OCD among us, could it either be randomized, ordered by
when people acked, or alphabetized?  Sorry if this sounds really
trivial, but it's kind of like trying to hold a conversation with
someone at their office when the cord to their phone was all twisted
up; it's really difficult to pay attention to anything of substance
until that problem is fixed (though, thankfully, a job change in
combination with cell phone prevalence have almost completely
eradicated the phone cord problem years ago).

I'm kinda worried that sending this will result in someone
alphabetizing everyone in the list except me, but oh well...

Elijah

  parent reply	other threads:[~2019-10-09 18:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07  3:38 What's cooking in git.git (Oct 2019, #02; Mon, 7) Junio C Hamano
2019-10-08 19:36 ` jk/code-of-conduct, was " Johannes Schindelin
2019-10-09  0:14   ` Raise your hand to Ack jk/code-of-conduct if your Ack fell thru cracks Junio C Hamano
2019-10-09  0:22     ` Taylor Blau
2019-10-09  1:41     ` Emily Shaffer
2019-10-09  8:07       ` Johannes Schindelin
2019-10-09  1:48     ` Jonathan Nieder
2019-10-09 10:36     ` Christian Couder
2019-10-09 15:13     ` Phillip Wood
2019-10-09 18:29     ` Elijah Newren [this message]
2019-10-09 19:37       ` Junio C Hamano
2019-10-09 19:52     ` William Baker
2019-10-09 20:50     ` CB Bailey
2019-10-10  0:18     ` Eric Wong
2019-10-11  5:58       ` Jeff King
2019-10-17 13:56         ` Philip Oakley
2019-10-11  4:39     ` Junio C Hamano
2019-10-11  6:01       ` Jeff King
2019-10-09  1:39   ` jk/code-of-conduct, was Re: What's cooking in git.git (Oct 2019, #02; Mon, 7) SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABPp-BGjaOofi_gWEatKnnkpY04OOyMDZucXqQ-FPYw8yeCacw@mail.gmail.com \
    --to=newren@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).