From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: vd/sparse-sparsity-fix-on-read (Was: Re: What's cooking in git.git (Nov 2021, #05; Fri, 19))
Date: Mon, 22 Nov 2021 09:59:44 -0800 [thread overview]
Message-ID: <CABPp-BGdhwcVhGPeY+09MMv+0384TY+OOimtBUgFE0Wv09riDA@mail.gmail.com> (raw)
In-Reply-To: <xmqqa6hznvz1.fsf@gitster.g>
On Fri, Nov 19, 2021 at 11:53 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> * vd/sparse-sparsity-fix-on-read (2021-10-27) 3 commits
> - sparse-index: update do_read_index to ensure correct sparsity
> - sparse-index: add ensure_correct_sparsity function
> - test-read-cache.c: prepare_repo_settings after config init
>
> Ensure that the sparseness of the in-core index matches the
> index.sparse configuration specified by the repository immediately
> after the on-disk index file is read.
>
> Will merge to 'next'?
I spotted two minor things with the commit message of the final patch
(which don't necessarily need to block the series, but would be nice
to see fixed)[1]. Otherwise the series looks ready to me, and Stolee
also put his stamp of approval on the series[2]. Perhaps wait to see
if Victoria wants to fix up those two small things I pointed out
before merging down?
[1] https://lore.kernel.org/git/CABPp-BGU=HHeydt3arF=RF2P81cFbe3NfX6tqiBHb8xkhOALgg@mail.gmail.com/
[2] https://lore.kernel.org/git/e1c6fe43-ebd1-7c6f-c5b6-c528fb4e6774@gmail.com/
next prev parent reply other threads:[~2021-11-22 18:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 7:10 What's cooking in git.git (Nov 2021, #05; Fri, 19) Junio C Hamano
2021-11-20 11:18 ` Fabian Stelzer
2021-11-20 17:30 ` Elijah Newren
2021-11-20 22:20 ` vd/sparse-reset (Was: Re: What's cooking in git.git (Nov 2021, #05; Fri, 19)) Elijah Newren
2021-11-21 2:00 ` What's cooking in git.git (Nov 2021, #05; Fri, 19) Elijah Newren
2021-11-22 17:59 ` Elijah Newren [this message]
2021-11-22 18:00 ` Glen Choo
2021-11-22 18:05 ` Junio C Hamano
2021-11-22 22:36 ` Glen Choo
2021-11-23 13:22 ` ab/mark-leak-free-tests-even-more (was: What's cooking in git.git (Nov 2021, #05; Fri, 19)) Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPp-BGdhwcVhGPeY+09MMv+0384TY+OOimtBUgFE0Wv09riDA@mail.gmail.com \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).