From: Elijah Newren <newren@gmail.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] parse-options.h: use designated initializers in OPT_* macros
Date: Mon, 20 Mar 2023 09:53:28 -0700 [thread overview]
Message-ID: <CABPp-BGXuQEef1Z2fDeHNJi=RSiTK1Jp1PehCtFvT1nzvJmoYw@mail.gmail.com> (raw)
In-Reply-To: <20230319165648.656738-1-szeder.dev@gmail.com>
On Sun, Mar 19, 2023 at 10:06 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> Use designated initializers in the expansions of the OPT_* macros to
> make it more readable which one-letter macro parameter initializes
> which field in the resulting 'struct option'.
This series makes the code easier for me to read; thanks for
submitting them. The series is pretty short and easy to read, and I
couldn't find any issues anywhere.
Reviewed-by: Elijah Newren <newren@gmail.com>
prev parent reply other threads:[~2023-03-20 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 16:56 [PATCH 0/3] parse-options.h: use designated initializers in OPT_* macros SZEDER Gábor
2023-03-19 16:56 ` [PATCH 1/3] parse-options.h: use consistent name for the callback parameters SZEDER Gábor
2023-03-19 16:56 ` [PATCH 2/3] parse-options.h: rename _OPT_CONTAINS_OR_WITH()'s parameters SZEDER Gábor
2023-03-20 18:16 ` Junio C Hamano
2023-03-19 16:56 ` [PATCH 3/3] parse-options.h: use designated initializers in OPT_* macros SZEDER Gábor
2023-03-20 16:53 ` Elijah Newren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BGXuQEef1Z2fDeHNJi=RSiTK1Jp1PehCtFvT1nzvJmoYw@mail.gmail.com' \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).