From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=1.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,LIST_MIRROR_RECEIVED,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id ADD471F852 for ; Fri, 4 Feb 2022 17:56:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377165AbiBDR4L (ORCPT ); Fri, 4 Feb 2022 12:56:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231603AbiBDR4K (ORCPT ); Fri, 4 Feb 2022 12:56:10 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A38F0C061714 for ; Fri, 4 Feb 2022 09:56:10 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id s13so21677156ejy.3 for ; Fri, 04 Feb 2022 09:56:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xZZ+N+ie3i+ugzCjkB7J0sDap6yZ0p4Ks7AfEfDfkNc=; b=JXigntwZ0WPxbYOFUCEbxjJUb95pwkXtzzW0Dn56TfniNJcOH0n3a5MSvZLC73cAZQ r0dGVXB6krdSohrFe8cdyE4HhV8x0nEc4hWiHMj/s0/9RB4CH2G65rbXNARSkl8VmfJj BN9ZDl4PkBt8ba4oWjdlLVpQaZzhHoUG80vxBLnGXCyuzXrpwqaTr7SsrAEqc2Hy63Nv UHqJRBfrn5ew0N8JYF8J+qlTl82y01FElbw9UqFD17NrwaGMVnWx8dw+eAn4bJTpmANC tr8ss8nCh1CGFfKr1SHGRu/Luq3goU+zIXJQo5MzWhP1i0IPDz98jEtnFA9zbf7/BvtZ /hjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xZZ+N+ie3i+ugzCjkB7J0sDap6yZ0p4Ks7AfEfDfkNc=; b=Cj+fo+fCkTode9C/cNfYLokJsn2WQAnSoQomGUrgOvsdEzCFb6+FkqO99Q0/S3patl iEzBTF1MbkbPu55U4ed7Z2axFu0MTc5/RwzNJpn4MBdT0ZKVhO/m+YBFM+FNt7uCIkOm Yjp+6hTxGisNqSnUJ9TXvjkh1qA5IxL5mYLrhv51/ipzIgAnxFJLq/WI/pLgzmLNj/X3 2HjZfqBeVo4/PYbOuaFu+AISPSmvewUj0oEUGyPhEnyPE3OK4iRhKnt9sOWpkFJIOt/Y oGa1zLJLTHFHiYPbk77AaBhYDyKuVpF+VVPKvlVVL+PRMAlPQI6wKtxQf/OfUH/YKRQn Ga4A== X-Gm-Message-State: AOAM533eiGE7SO269Asxh0GrZDUu/GzAcT7dTVUrStEf/ic1ac9D+9tD be+PvTfpGNdAr1zUfQLMrwL2c3Y9Qri9/5LvXVs= X-Google-Smtp-Source: ABdhPJxdCi1Lm5UrjgQKJb7nqRnoWrtoxKZr28kVUu9hSb0GeAZMK6E2e7NbqvyGPlCaNjYxcz8cGTjDp5MAB3jE7QU= X-Received: by 2002:a17:907:60d6:: with SMTP id hv22mr52057ejc.476.1643997369085; Fri, 04 Feb 2022 09:56:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Elijah Newren Date: Fri, 4 Feb 2022 09:55:57 -0800 Message-ID: Subject: Re: [PATCH v6 0/3] completion: sparse-checkout updates To: Junio C Hamano Cc: Lessley Dennington via GitGitGadget , Git Mailing List , Derrick Stolee , johannes.schindelin@gmail.com, Taylor Blau , =?UTF-8?Q?SZEDER_G=C3=A1bor?= , Lessley Dennington , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Feb 4, 2022 at 9:04 AM Junio C Hamano wrote: > > Elijah Newren writes: > > >> Changes since V5 > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> > >> * Fix incorrect conditional that was causing failure of non-cone mode= test > >> (and causing 'seen' CI to fail). > >> * Remove __git_comp_directories indentation changes between the secon= d and > >> third commits. > > > > This round looks good to me: > > > > Reviewed-by: Elijah Newren > > > > Nice work! > > Thanks, both. Will queue. Let's mark it to be merged down to > 'next' soonish. =C3=86var had a good comment about code coverage on Windows that we might want to address first[1]. (Namely, splitting one test into two -- one that tests a path with backslashes that can be skipped on windows, and a separate test that checks paths with spaces, tabs, and non-ascii that can be run on all platforms.) But other than that, yeah, this should be ready for 'next'. [1] https://lore.kernel.org/git/220204.86h79f45nf.gmgdl@evledraar.gmail.com= /