From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 01B9D1F953 for ; Fri, 31 Dec 2021 22:26:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbhLaWZ6 (ORCPT ); Fri, 31 Dec 2021 17:25:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231852AbhLaWZ6 (ORCPT ); Fri, 31 Dec 2021 17:25:58 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD99AC061574 for ; Fri, 31 Dec 2021 14:25:57 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id x15so112755045edv.1 for ; Fri, 31 Dec 2021 14:25:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=96aItz+XaQ+egzMd5Tj7DNXDYV0/WPeTZfgzIOjxA2U=; b=XDha/mcr3mNSdNG9sIs7xW2pAt7YNED5LsNyBE359Y3C28serVvIOsofWSkN0LgsIY WlXwlV0AD1fpuK2dF/84mw/JjpGWR8KfC3/8UnWYc+iqm8HsVqKb1YtWizmbcYseiaX8 meGFsouYaWb4dfrEgJZ9yYW1uJ8fZQxlxASbWnZPTtSC7WwR5SyWMs5DlF3BaJzjpUVp NM6iIqyLzvm4Hpkt9fnaqGNTOKQzNRoAx9MPlzuYA8BDAxMeVJTjiVVqhf8xuBsJUq8Q 3ByvCYu97row7eIiK38Mn7K4/tSDLcDocG6EFR3dZ98XInJtEza6w90DUjBXMuQeUx6A c3EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=96aItz+XaQ+egzMd5Tj7DNXDYV0/WPeTZfgzIOjxA2U=; b=y0jnZ37B62tkRDIl8DWXdzM7yWVBTm3cbHp3NOrSS2X9NrOvFrqT1PSantnx18bT3l sfr25QL7RcHL7iDyJDcsppdK/vqLtG6W5mKVrCeo9ozjMtSxL7HJuKbLjpapMsNfwqnY SODz1f5+9gq5aR6ml5JvOyRAFUTud4ALeb130fKLvDrDPFUqK8kaMvu2g2YmeT7G/kXf G9sMkH/mBsTihbS1GjPAWBAwd4IJmmaU2eDNSC+0YkpBZ7ukcvguQ2Cge2jUIz893ddc N01wYwPLL9VQvurZrqFWouj0R0zRa8bcP44QAznPVw3d/iQSLu44mMsnpXOSr3H6JOdz ipvg== X-Gm-Message-State: AOAM530nP6P2UUmeiOwihjzg535TZ3zT5dvPsC2IaVVRQx6eqCcAuw1m XzikzjPoChjSlONsytQmfATRiVItoUqiZn1Qhb6wgkbfXvU= X-Google-Smtp-Source: ABdhPJygL4CI2kfSWfZSV0pysEyHUpNwI82dlx7PZ8NemBicKVgwyAce5lRuy8GrzWO2Y2ICkThcb5OUqddtNlRXJ2o= X-Received: by 2002:a50:da48:: with SMTP id a8mr34967413edk.146.1640989556158; Fri, 31 Dec 2021 14:25:56 -0800 (PST) MIME-Version: 1.0 References: <955fcab00528464b5450bd22b45c89ffc2283e39.1640892413.git.gitgitgadget@gmail.com> In-Reply-To: From: Elijah Newren Date: Fri, 31 Dec 2021 14:25:45 -0800 Message-ID: Subject: Re: [PATCH v2 1/2] sparse-checkout: custom tab completion tests To: Junio C Hamano Cc: Lessley Dennington via GitGitGadget , Git Mailing List , Derrick Stolee , johannes.schindelin@gmail.com, Lessley Dennington Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Dec 31, 2021 at 2:21 PM Junio C Hamano wrote: > > Elijah Newren writes: > > > Second, and this item is unrelated to your series but your comment > > made me realize it....sparse-checkout unfortunately ignores prefix and > > creates a bad .git/info/sparse-checkout file. For example: > > ... > > I think the loss of the current working directory will be fixed by the > > en/keep-cwd directory (currently in next and marked for merging to > > master), but the fact that the wrong paths end up in the > > sparse-checkout file is unfortunate. It basically means that the > > `set` and `add` subcommands of `sparse-checkout` can only be safely > > run from the toplevel directory. > > You made it sound as if this is a fundamental limitation, but it > sounds more like a bug that needs to be fixed (outside the > completion series, of course) to me. Oh, sorry, I didn't mean to imply that. I meant the same thing you say here: it's another bug we need to fix, in a separate series.