From: Elijah Newren <newren@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] merge-ort unused parameter cleanups
Date: Fri, 15 Sep 2023 19:56:10 -0700 [thread overview]
Message-ID: <CABPp-BFzAX3b_Dm+fVcuNSKw2=7U3x747Ws7RMyWPxQ3GTNvzw@mail.gmail.com> (raw)
In-Reply-To: <20230914093409.GA2254811@coredump.intra.peff.net>
On Thu, Sep 14, 2023 at 2:34 AM Jeff King <peff@peff.net> wrote:
>
> A few small cleanups for merge-ort collected from playing with
> -Wunused-parameter. The first one actually fixes a user-visible bug, and
> the rest are just cleanups.
>
> [1/4]: merge-ort: drop custom err() function
> [2/4]: merge-ort: stop passing "opt" to read_oid_strbuf()
> [3/4]: merge-ort: drop unused parameters from detect_and_process_renames()
> [4/4]: merge-ort: drop unused "opt" parameter from merge_check_renames_reusable()
>
> merge-ort.c | 48 +++++++++++--------------------------------
> t/t6406-merge-attr.sh | 3 ++-
> 2 files changed, 14 insertions(+), 37 deletions(-)
>
> -Peff
All look good; thanks.
next prev parent reply other threads:[~2023-09-16 2:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 9:34 [PATCH 0/4] merge-ort unused parameter cleanups Jeff King
2023-09-14 9:39 ` [PATCH 1/4] merge-ort: drop custom err() function Jeff King
2023-09-16 2:54 ` Elijah Newren
2023-09-16 5:50 ` Jeff King
2023-09-14 9:39 ` [PATCH 2/4] merge-ort: stop passing "opt" to read_oid_strbuf() Jeff King
2023-09-14 9:39 ` [PATCH 3/4] merge-ort: drop unused parameters from detect_and_process_renames() Jeff King
2023-09-16 3:04 ` Elijah Newren
2023-09-14 9:40 ` [PATCH 4/4] merge-ort: drop unused "opt" parameter from merge_check_renames_reusable() Jeff King
2023-09-16 3:09 ` Elijah Newren
2023-09-16 5:52 ` Jeff King
2023-09-16 2:56 ` Elijah Newren [this message]
2023-09-16 6:00 ` [PATCH 5/4] merge-ort: lowercase a few error messages Jeff King
2023-09-16 7:29 ` Jeff King
2023-09-16 21:49 ` Junio C Hamano
2023-09-16 22:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BFzAX3b_Dm+fVcuNSKw2=7U3x747Ws7RMyWPxQ3GTNvzw@mail.gmail.com' \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).