From: Elijah Newren <newren@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] revisions(7): clarify that most commands take a single revision range
Date: Thu, 20 May 2021 09:40:33 -0700 [thread overview]
Message-ID: <CABPp-BFhsw7jMZa9TcLSKz12=0H40froS-DTRXSvMR4q006Jyw@mail.gmail.com> (raw)
In-Reply-To: <ab2d8b16-42db-9675-083a-efa7cfca6e4c@gmail.com>
On Wed, May 19, 2021 at 7:28 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 18/05/21 18.17, Junio C Hamano wrote:
> > +Commands that are specifically designed to take two distinct ranges
> > +(e.g. "git range-diff R1 R2" to compare two ranges) do exist, but
> > +they are exceptions. Unless otherwise noted, all "git" commands
> > +that operate on a set of commits work on a single revision range.
> > +In other words, writing two "two-dot range notation" next to each
> > +other, e.g.
> > +
> > + $ git log A..B C..D
> > +
> > +does *not* specify two revision ranges for most commands. Instead
> > +it will name a single connected set of commits, i.e. those that are
> > +reachable from either B or D but are reachable from neither A or C.
> > +In a linear history like this:
> > +
> > + ---A---B---o---o---C---D
> > +
Why did you snip off the immediate next part of Junio's text which said:
+because A and B are reachable from C, the revision range specified
+by these two dotted ranges is a single commit D.
Is this sentence hard to parse or confusing in some way? I thought
this sentence would have made it pretty clear that the answer to this
question:
>
> So "git log A..B C..D" is same as "A..D", right?
was 'no', so I'm curious if that particular final sentence's wording
could be improved.
next prev parent reply other threads:[~2021-05-20 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 11:17 [PATCH] revisions(7): clarify that most commands take a single revision range Junio C Hamano
2021-05-20 2:27 ` Bagas Sanjaya
2021-05-20 4:58 ` Junio C Hamano
2021-05-20 5:02 ` Junio C Hamano
2021-05-20 5:26 ` Bagas Sanjaya
2021-05-20 16:45 ` Elijah Newren
2021-05-20 16:53 ` Eric Sunshine
2021-05-20 16:40 ` Elijah Newren [this message]
2021-05-21 19:19 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BFhsw7jMZa9TcLSKz12=0H40froS-DTRXSvMR4q006Jyw@mail.gmail.com' \
--to=newren@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).