git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Elijah Newren <newren@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: Anyone know what is creating commits with bogus dates?
Date: Thu, 21 May 2020 10:49:17 -0700	[thread overview]
Message-ID: <CABPp-BFfa6q96qMUN07Dq3di6d3WuUzhyktBytbX=FGgarXgjg@mail.gmail.com> (raw)

Hi,

I wanted to report that we seem to have a number of repos in the wild
with bogus (as in "won't even parse") dates.

I first discovered such a repository in the wild a while ago with
rails.git.  It has a commit with a recorded timezone of "+051800" for
both author and committer.  Everything else about the commit looks
fine.  See https://github.com/rails/rails/commit/4cf94979c9f4d6683c9338d694d5eb3106a4e734.

Some google searches at the time turned up a few other examples, all
with the same "+051800" issue.  I put a special workaround for it into
filter-repo because I figured it was slightly prominent but probably
limited to that special timezone.  The fact that it was six digits but
the last two were zeros made it seem not quite as bad as it could be.


Recently, I've gotten a few reports of commits existing in live repos
with other forms of breakage.  Dates that correspond to roughly a
hundred years in the future, and with timezone specifiers that are
either 7 or 8 digits long and no leading or trailing zeros.  See
https://github.com/newren/git-filter-repo/issues/88.

Is there rogue software somewhere creating some bad commit objects?
Does anyone have any idea what might be causing these?  Any
suggestions on the right course(s) of action?

Right now, I'm leaning towards saying fast-import is right to bail on
these, and maybe I'll investigate having filter-repo waste some cycles
to try to detect these and report more helpful errors (though I really
want to avoid full sanity checking as that's expensive).  If I go that
route, I'll probably make it link to the example command I provided in
that bug report showing users how they can use filter-repo to fix
those problems.  Does that sound sane?  Anything I'm missing?


Thanks,
Elijah

             reply	other threads:[~2020-05-21 17:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 17:49 Elijah Newren [this message]
2020-05-21 18:12 ` Anyone know what is creating commits with bogus dates? Eric Sunshine
2020-05-21 18:57 ` Jeff King
2020-05-21 19:31   ` Elijah Newren
2020-05-21 19:55     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPp-BFfa6q96qMUN07Dq3di6d3WuUzhyktBytbX=FGgarXgjg@mail.gmail.com' \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).